KUAN-HSUN-LI commented on a change in pull request #752: URL: https://github.com/apache/submarine/pull/752#discussion_r711659973
########## File path: submarine-sdk/pysubmarine/submarine/store/model_registry/abstract_store.py ########## @@ -0,0 +1,234 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from abc import ABCMeta, abstractmethod +from typing import List + +from submarine.entities.model_registry import ModelVersion, RegisteredModel + + +class AbstractStore: + """ + Abstract class for Backend model registry + This class defines the API interface for frontends to connect with various types of backends. + """ + + __metaclass__ = ABCMeta + + def __init__(self) -> None: + """ + Empty constructor for now. This is deliberately not marked as abstract, else every + derived class would be forced to create one. + """ + pass + + @abstractmethod + def create_registered_model( Review comment: model registry including `registered_model`, `registered_model_tag`, `model_version`, `model_version_tag` four tables. tracking including `param`, `metric`, `experiment` three tables. In my opinion, it is more clear to put these functions in different directories. In this PR, I only worked on the model registry directory maybe I should also refactor the tracking directory and implement the `experiment` table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
