Kenchu123 opened a new pull request #788:
URL: https://github.com/apache/submarine/pull/788


   ### What is this PR for?
   <!-- A few sentences describing the overall goals of the pull request's 
commits.
   First time? Check out the contributing guide - 
https://submarine.apache.org/contribution/contributions.html
   -->
   The submarine operator is responsible for creating the submarine. However, 
it will create the submarine with settings written in code currently.
   
   We want to make it read settings from yaml files, so that others can easily 
change the settings.
   
   ### What type of PR is it?
   Improvement
   
   ### Todos
   * [x] - Add artifacts
   * [x] - Add YAML file parser
   
   ### What is the Jira issue?
   <!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
   * Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. 
`SUBMARINE-23. PR title`
   -->
   
   https://issues.apache.org/jira/browse/SUBMARINE-1054
   
   ### How should this be tested?
   <!--
   * First time? Setup Travis CI as described on 
https://submarine.apache.org/contribution/contributions.html#continuous-integration
   * Strongly recommended: add automated unit tests for any new or changed 
behavior
   * Outline any manual steps to test the PR here.
   -->
   
   Run operator e2e test: `go test ./test/e2e`
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to