joshvictor1024 commented on pull request #816: URL: https://github.com/apache/submarine/pull/816#issuecomment-985750179
Another issue I found is that [Prettier](https://prettier.io/), which is used in `submarine-cloud-v2/`, will always break linting for multiline flow sequences (the `[]` list). An example would be line 64 of [`submarine-cloud-v2/artifacts/submarine/submarine-mlflow.yaml`](https://github.com/apache/submarine/blob/1133f2bb47b7eda81fbd181e51d474dc323f16df/submarine-cloud-v2/artifacts/submarine/submarine-mlflow.yaml#L64) ```yaml # output of prettier (4 spaces for items inside "[]", 2 spaces anywhere else) Item: Item-1: [ "item-a", "item-b", ] Item-2: item-a Item-3: item-a # expected: consistent indentation (2 spaces) Item: Item-1: [ "item-a", "item-b", ] Item-2: item-a Item-3: item-a # work-around: no flow styles, only block styles? Item: Item-1: - "item-a", - "item-b", Item-2: item-a Item-3: item-a ``` We might need to give up Prettier if we want to use linting for indentation... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
