cdmikechen opened a new pull request #844:
URL: https://github.com/apache/submarine/pull/844


   ### What is this PR for?
   Jupyter Notebook have created a workspace volume /home/jovyan/workspace, but 
in some cases, we may need to do some initialization configuration when 
starting notebook. For example, we can configure an overrides.json in 
/opt/conda/share/jupyter/lab/settings/.
   We can refer to the official document of jupyter about overrides.json.
   
<https://jupyterlab.readthedocs.io/en/stable/user/directories.html#overrides-json>
   
   Assuming that the user of submarine needs to specify the language of the 
initialized notebook to Chinese, we can write this in overrides.json.
   
   ```json
   {
     "@jupyterlab/translation-extension:plugin": {
       "locale": "zh_CN"
     }
   }
   ```
   After this configuration, the new logging will be displayed in Chinese by 
default.
   
   
   ### What type of PR is it?
   Improvement
   
   ### Todos
   * [x] - Add a configmap to use `overwrite.json` as a volume config file in 
pod
   
   ### What is the Jira issue?
   
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1127?filter=allissues
   
   ### How should this be tested?
   Try to set an env named `SUBMARINE_NOTEBOOK_DEFAULT_OVERWRITE_JSON` in 
submarine-server deployment.
   
   ### Screenshots (if appropriate)
   No
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? Yes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to