pingsutw commented on a change in pull request #848:
URL: https://github.com/apache/submarine/pull/848#discussion_r775621495
##########
File path:
submarine-server/server-api/src/main/java/org/apache/submarine/server/api/Submitter.java
##########
@@ -44,10 +44,11 @@
/**
* Create experiment with spec
* @param spec experiment spec
+ * @param id experimentId
* @return object
* @throws SubmarineRuntimeException running error
*/
- Experiment createExperiment(ExperimentSpec spec) throws
SubmarineRuntimeException;
+ Experiment createExperiment(ExperimentSpec spec, String experimentId) throws
SubmarineRuntimeException;
Review comment:
We already have `experimentId` in `ExperimentSpec`.
Check `ExperimentSpec` -> `ExperimentMeta` -> `experimentId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
