cdmikechen opened a new pull request #870:
URL: https://github.com/apache/submarine/pull/870


   ### What is this PR for?
   The current K8sSubmitter contains a lot of CRD processing logic in addition 
to the implementation of the interface. 
   The purpose of this PR is to split the CRD processing logic from the class 
as far as possible and merge it into the resource object for processing.
   
   The current PR refactored part of the code so that we can see the changes of 
the code after refactoring.
   
   ### What type of PR is it?
   Refactoring
   
   ### Todos
   * [x] - Refactoring `K8sSubmitter`  involving Notebook create and delete 
method
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-1174
   
   ### How should this be tested?
   The refactored codes can use the original test case.
   
   ### Screenshots (if appropriate)
   No
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to