atosystem commented on a change in pull request #871:
URL: https://github.com/apache/submarine/pull/871#discussion_r786409623
##########
File path: submarine-sdk/pysubmarine/submarine/cli/notebook/command.py
##########
@@ -15,24 +15,132 @@
under the License.
"""
+import json
+import time
+
import click
+from rich.console import Console
+from rich.json import JSON as richJSON
+from rich.panel import Panel
+from rich.table import Table
+
+from submarine.cli.config.config import loadConfig
+from submarine.client.api.notebook_client import NotebookClient
+from submarine.client.exceptions import ApiException
+
+submarineCliConfig = loadConfig()
+if submarineCliConfig is None:
+ exit(1)
Review comment:
@pingsutw I have already raised the error message in `loadConfig`
https://github.com/apache/submarine/blob/efb4e7c578f9ee5188414b2140ab7b4a9de1ec92/submarine-sdk/pysubmarine/submarine/cli/config/config.py#L103-L114
Do I have to change the place to raise the error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
