MortalHappiness commented on code in PR #937:
URL: https://github.com/apache/submarine/pull/937#discussion_r859803982
##########
dev-support/cicd/README.md:
##########
@@ -21,44 +22,53 @@ To use them more easily, we provide a Docker image to help
committer to handle t
## Docker mode
+Build the image and start the container
+
```
./build_and_start_cicd_image.sh
```
-Or
+Or separate image building and container running process
```
-cd <path-to-submarine-home>/dev-support/cicd
-docker build -t submarine-cicd .
-docker run -it --rm submarine-cicd
+./build.sh
+docker run -it --rm apache/submarine:cicd-0.7.0
```
-Jira username, password, apache id and apache username are required in the
docker container. You can
-add them to the local environment variable.
+Or directly use the image on docker hub
```
-vi ~/.bash_profile
-export JIRA_USERNAME='Your jira username'
-export JIRA_PASSWORD='Your jira password'
-export APACHE_ID='Your apache id' # Your apache email prefix
-export APACHE_NAME='Your apache name'
+docker run -it --rm apache/submarine:cicd-0.7.0
```
-And you'll see output like below and then you can decide what to accomplish.
+After successfully running the container, you will see output like below and
then you can decide what to accomplish.
+
```
-$ docker run -it -e JIRA_USERNAME="${JIRA_USERNAME}" -e
JIRA_PASSWORD="${JIRA_PASSWORD}" -e APACHE_ID="${APACHE_ID}" -e
APACHE_NAME="${APACHE_NAME}" -p 4000:4000 --rm submarine-cicd
+Start Submarine CI/CD.
+==== Merge PR Begin ====
+Enter Your Apache JIRA User name:
```
-The screen outputs the following information:
+Jira username, password, apache id and apache username can be provided to the
docker container so that you do not need to type them everytime. You can add
them to the local environment variable file.
+
+For example, create a file named `~/.secrets/submarine-cicd.env` and write the
following content to it.
```
-Start Submarine CI/CD.
-==== Merge PR Begin ====
-Enter Your Apache JIRA User name:
+JIRA_USERNAME=YOUR_JIRA_USERNAME
+JIRA_PASSWORD=YOUR_JIRA_PASSWORD
+APACHE_ID=YOUR_APACHE_ID
+APACHE_NAME=YOUR_APACHE_NAME
+```
+
+And then you can run the docker image with the following command
+
```
+docker run -it --env-file ~/.secrets/submarine-cicd.env -p 4000:4000 --rm
apache/submarine:cicd-0.7.0
Review Comment:
@jeff-901 Original README.md also forwards port 4000. I just follow it and
also do not know why. Maybe we can remove it if it is useless?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
