JackLiu00521 commented on code in PR #943:
URL: https://github.com/apache/submarine/pull/943#discussion_r862887524
##########
.github/workflows/master.yml:
##########
@@ -556,9 +556,9 @@ jobs:
run: |
yarn add prettier@^2.6.2
yarn checkformat
- sonarcloud:
+ sonarcloud-and-codecov:
if: github.repository == 'apache/submarine' && github.event_name == 'push'
&& github.ref == 'refs/heads/master'
Review Comment:
Ok, I just changed the position of if statement into sonarcloud's own step.
Thank's Kevin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
