cdmikechen commented on PR #969:
URL: https://github.com/apache/submarine/pull/969#issuecomment-1159844787
```java
ConfVars(String varName, VarType type) {
switch(type) {
case STRING:
this.varName = varName;
this.varClass = String.class;
if (varName == "submarine.server.ssl.key.manager.password" ||
varName == "submarine.server.ssl.truststore.path" ||
varName == "submarine.server.ssl.truststore.type" ||
varName == "submarine.server.ssl.truststore.password"
) {
this.stringValue = null;
} else {
this.stringValue = System.getenv(varName);
}
this.intValue = -1;
this.floatValue = -1;
this.longValue = -1;
this.booleanValue = false;
break;
```
I don't think it is a good way to remove the default value from the method
parameters and use `if/else` to judge.
Maybe it is a better choice for us to convert xml and variables by `enum` or
`properties` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
