joshvictor1024 commented on PR #959: URL: https://github.com/apache/submarine/pull/959#issuecomment-1165159158
@cdmikechen Right now, the labels created with `submarine-cloud-v3` match those created with `submarine-cloud-v2`. I think convenience is outside the scope of this PR. We could add that label along with others such as `app.kubernetes.io/created-by=controller-runtime` in a separate PR for easy reviewing. Also, if I understand the guide you provided correctly, should the label `app.kubernetes.io/name=submarine` also be applied to the resources created by Helm, like `deployment.apps/training-operator`? In that case, I think those are again outside the scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
