ianshen1104 commented on code in PR #976: URL: https://github.com/apache/submarine/pull/976#discussion_r935977079
########## submarine-cloud-v3/artifacts/submarine-database.yaml: ########## @@ -20,6 +20,10 @@ apiVersion: v1 kind: PersistentVolumeClaim metadata: name: submarine-database-pvc + labels: + app.kubernetes.io/name: submarine-database + app.kubernetes.io/version: "0.8.0-SNAPSHOT" + app.kubernetes.io/component: database spec: Review Comment: Thank you for your suggestion @MortalHappiness, I have changed the code to perform label setting in golang functions instead of yaml files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
