cdmikechen opened a new pull request, #992:
URL: https://github.com/apache/submarine/pull/992

   ### What is this PR for?
   The model serve now registers the wrong namespace for resources, and taking 
the model name directly as a resource name can lead to problems with illegal 
characters.
   
![image](https://user-images.githubusercontent.com/12069428/187067306-98067ede-1c8a-4c0a-b356-96607519d40e.png)
   
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [x] - Model serve codes refactoring.
   * [x] - Replace default to submarine-server namespace.
   * [x] - Replace model name to model version in k8s resource metadata name. 
   * [x] - Add save_model method in example quick-start .
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1315
   
   ### How should this be tested?
   No test cases will be added for the time being, pending discussion of 
subsequent processing.
   
   ### Screenshots (if appropriate)
   No
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? Yes
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to