cdmikechen commented on PR #1125: URL: https://github.com/apache/submarine/pull/1125#issuecomment-2043913999
@laiyousin @xunliu `submarine.auth.default.secret` is not hard-coded and can be overridden by `SUBMARINE_AUTH_DEFAULT_SECRET` in the environment variable. Therefore, I think this PR still needs more consideration, and there are too many problems in CI that have not been solved, and it still needs the support of other fixes to merge. Refer to the documentation https://submarine.apache.org/docs/designDocs/wip-designs/security-implementation#authentication for more authentication details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
