Author: rhuijben
Date: Mon Jan 4 16:02:10 2010
New Revision: 895672
URL: http://svn.apache.org/viewvc?rev=895672&view=rev
Log:
* STATUS: Cast some votes, approving two patches
Modified:
subversion/branches/1.6.x/STATUS
Modified: subversion/branches/1.6.x/STATUS
URL:
http://svn.apache.org/viewvc/subversion/branches/1.6.x/STATUS?rev=895672&r1=895671&r2=895672&view=diff
==============================================================================
--- subversion/branches/1.6.x/STATUS (original)
+++ subversion/branches/1.6.x/STATUS Mon Jan 4 16:02:10 2010
@@ -73,22 +73,6 @@
+0: lgo - code reviewed and looks good, but I don't have access to a
Windows machine.
- * r879093
- Fix bug where svn_[rangelist|mergeinfo]_[merge|intersect|remove|diff]
- APIs can modify their *non*-output arguments.
- Justification:
- No reports of this causing any problems that I know of, which is
- probably due to the fact that users of an API like svn_mergeinfo_merge
- typically only care about the output arguments. The new C tests added
- to mergeinfo-test.c clearly demonstrate the bug.
- Branch:
- Resolves a minor conflict in libsvn_client/merge.c where the code
- changed was refactored on trunk.
- ^/subversion/branches/1.6.x-r39019
- The relevant commit on the branch is r879175.
- Votes:
- +1: pburba, julianfoad
-
* r879766
Fix issue #3498: Subversion password stores freeze Eclipse
Justification:
@@ -124,7 +108,7 @@
blocking on reads from sockets after days of inactivity on the
connection, a problem seen and reported by MPlayer developers in #svn.
Votes:
- +1: stsp
+ +1: stsp, rhuijben
* r892050, 892085
Fix a reintegrate bug which can occur when the merge source has mergeinfo
@@ -135,7 +119,7 @@
target. This occured in our own repository, see
http://svn.haxx.se/dev/archive-2009-12/0338.shtml.
Votes:
- +1: pburba
+ +1: pburba, rhuijben
* r891672
Fix issue #3552 - File external from URL cannot overwrite the existing
@@ -151,14 +135,6 @@
Votes:
+1: stylesen
- * r895653
- Update test expectations in the swig-py tests to take the recent mergeinfo
- canonicalization changes into account.
- Justification:
- Passing tests are Good.
- Votes:
- +1: hwright
-
Veto-blocked changes:
* r877552, r877617, r877618, r877619, r877621
@@ -194,3 +170,29 @@
Approved changes:
=================
+
+ * r879093
+ Fix bug where svn_[rangelist|mergeinfo]_[merge|intersect|remove|diff]
+ APIs can modify their *non*-output arguments.
+ Justification:
+ No reports of this causing any problems that I know of, which is
+ probably due to the fact that users of an API like svn_mergeinfo_merge
+ typically only care about the output arguments. The new C tests added
+ to mergeinfo-test.c clearly demonstrate the bug.
+ Branch:
+ Resolves a minor conflict in libsvn_client/merge.c where the code
+ changed was refactored on trunk.
+ ^/subversion/branches/1.6.x-r39019
+ The relevant commit on the branch is r879175.
+ Votes:
+ +1: pburba, julianfoad, rhuijben
+
+
+ * r895653
+ Update test expectations in the swig-py tests to take the recent mergeinfo
+ canonicalization changes into account.
+ Justification:
+ Passing tests are Good.
+ Votes:
+ +1: hwright, rhuijben
+ +1: stsp (via irc)