Author: pburba
Date: Fri Apr 23 13:44:59 2010
New Revision: 937296

URL: http://svn.apache.org/viewvc?rev=937296&view=rev
Log:
Follow-up to r937033.

* subversion/libsvn_repos/dump.c

  (svn_repos_dump_fs3): Replace needless apr_psprintf with string literal.
   Check for NULL progress_func.

Suggested by: gstein, rhuijben

Modified:
    subversion/trunk/subversion/libsvn_repos/dump.c

Modified: subversion/trunk/subversion/libsvn_repos/dump.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/dump.c?rev=937296&r1=937295&r2=937296&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/dump.c (original)
+++ subversion/trunk/subversion/libsvn_repos/dump.c Fri Apr 23 13:44:59 2010
@@ -1124,15 +1124,12 @@ svn_repos_dump_fs3(svn_repos_t *repos,
      the oldest dumped revision?  If so, then issue a final generic
      warning, since the inline warnings already issued might easily be
      missed. */
-  if (found_old_reference)
-    {
-      const char *warning = apr_psprintf(
-        subpool,
-        _("WARNING: The range of revisions dumped contained references to\n"
-          "WARNING: copy sources outside that range.\n"));
-      SVN_ERR(progress_func(progress_baton, SVN_INVALID_REVNUM, warning,
+  if (progress_func && found_old_reference)
+    SVN_ERR(progress_func(progress_baton, SVN_INVALID_REVNUM,
+                          _("WARNING: The range of revisions dumped "
+                            "contained references to\n"
+                            "WARNING: copy sources outside that range.\n"),
                             subpool));
-    }
 
   svn_pool_destroy(subpool);
 


Reply via email to