Author: artagnon
Date: Wed Sep 29 04:35:46 2010
New Revision: 1002466
URL: http://svn.apache.org/viewvc?rev=1002466&view=rev
Log:
svnrdump: dump_editor: Remove unnecessary iterpool
* subversion/svnrdump/dump_editor.c
(close_directory): Don't create a narrow iteration pool for just one
variable. It hits performance and gives no significant memory
benefits.
Modified:
subversion/trunk/subversion/svnrdump/dump_editor.c
Modified: subversion/trunk/subversion/svnrdump/dump_editor.c
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/svnrdump/dump_editor.c?rev=1002466&r1=1002465&r2=1002466&view=diff
==============================================================================
--- subversion/trunk/subversion/svnrdump/dump_editor.c (original)
+++ subversion/trunk/subversion/svnrdump/dump_editor.c Wed Sep 29 04:35:46 2010
@@ -495,7 +495,6 @@ close_directory(void *dir_baton,
{
struct dir_baton *db = dir_baton;
struct dump_edit_baton *eb = db->eb;
- apr_pool_t *iterpool;
apr_hash_index_t *hi;
LDR_DBG(("close_directory %p\n", dir_baton));
@@ -506,11 +505,8 @@ close_directory(void *dir_baton,
/* Some pending newlines to dump? */
SVN_ERR(dump_newlines(eb, &(eb->dump_newlines), pool));
- /* Create a pool just for iterations to allocate a loop variable */
- iterpool = svn_pool_create(pool);
-
/* Dump the deleted directory entries */
- for (hi = apr_hash_first(iterpool, db->deleted_entries); hi;
+ for (hi = apr_hash_first(pool, db->deleted_entries); hi;
hi = apr_hash_next(hi))
{
const void *key;
@@ -523,7 +519,6 @@ close_directory(void *dir_baton,
}
svn_hash__clear(db->deleted_entries, pool);
- svn_pool_destroy(iterpool);
return SVN_NO_ERROR;
}
