Author: hwright Date: Mon Oct 4 17:09:36 2010 New Revision: 1004324 URL: http://svn.apache.org/viewvc?rev=1004324&view=rev Log: Eliminate a few calls to strlen(), by just manually checking for the empty string.
Found by: Philipp Kloke <[email protected]> * subversion/libsvn_client/add.c (auto_props_enumerator): As above. * subversion/libsvn_diff/parse-diff.c (parse_range): Same. * subversion/libsvn_client/patch.c (match_hunk): Same. * subversion/libsvn_fs_fs/tree.c (fs_copied_from): Same. Modified: subversion/trunk/subversion/libsvn_client/add.c subversion/trunk/subversion/libsvn_client/patch.c subversion/trunk/subversion/libsvn_diff/parse-diff.c subversion/trunk/subversion/libsvn_fs_fs/tree.c Modified: subversion/trunk/subversion/libsvn_client/add.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/add.c?rev=1004324&r1=1004323&r2=1004324&view=diff ============================================================================== --- subversion/trunk/subversion/libsvn_client/add.c (original) +++ subversion/trunk/subversion/libsvn_client/add.c Mon Oct 4 17:09:36 2010 @@ -167,7 +167,7 @@ auto_props_enumerator(const char *name, apr_array_header_t *props; /* nothing to do here without a value */ - if (strlen(value) == 0) + if (*value == 0) return TRUE; /* check if filename matches and return if it doesn't */ Modified: subversion/trunk/subversion/libsvn_client/patch.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/patch.c?rev=1004324&r1=1004323&r2=1004324&view=diff ============================================================================== --- subversion/trunk/subversion/libsvn_client/patch.c (original) +++ subversion/trunk/subversion/libsvn_client/patch.c Mon Oct 4 17:09:36 2010 @@ -872,7 +872,7 @@ match_hunk(svn_boolean_t *matched, targe /* If the last line doesn't have a newline, we get EOF but still * have a non-empty line to compare. */ if ((hunk_eof && hunk_line->len == 0) || - (content_info->eof && strlen(target_line) == 0)) + (content_info->eof && *target_line == 0)) break; /* Leading/trailing fuzzy lines always match. */ Modified: subversion/trunk/subversion/libsvn_diff/parse-diff.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_diff/parse-diff.c?rev=1004324&r1=1004323&r2=1004324&view=diff ============================================================================== --- subversion/trunk/subversion/libsvn_diff/parse-diff.c (original) +++ subversion/trunk/subversion/libsvn_diff/parse-diff.c Mon Oct 4 17:09:36 2010 @@ -150,7 +150,7 @@ parse_range(svn_linenum_t *start, svn_li { char *comma; - if (strlen(range) == 0) + if (*range == 0) return FALSE; comma = strstr(range, ","); Modified: subversion/trunk/subversion/libsvn_fs_fs/tree.c URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/tree.c?rev=1004324&r1=1004323&r2=1004324&view=diff ============================================================================== --- subversion/trunk/subversion/libsvn_fs_fs/tree.c (original) +++ subversion/trunk/subversion/libsvn_fs_fs/tree.c Mon Oct 4 17:09:36 2010 @@ -2173,7 +2173,7 @@ fs_copied_from(svn_revnum_t *rev_p, if (copyfrom_str) { - if (strlen(copyfrom_str) == 0) + if (*copyfrom_str == 0) { /* We have a cached entry that says there is no copyfrom here. */
