Author: philip
Date: Mon Oct 25 11:51:22 2010
New Revision: 1027077
URL: http://svn.apache.org/viewvc?rev=1027077&view=rev
Log:
* subversion/libsvn_wc/adm_ops.c
(revert_internal): Add comment about recursion problem.
Modified:
subversion/trunk/subversion/libsvn_wc/adm_ops.c
Modified: subversion/trunk/subversion/libsvn_wc/adm_ops.c
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/adm_ops.c?rev=1027077&r1=1027076&r2=1027077&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/adm_ops.c (original)
+++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Mon Oct 25 11:51:22 2010
@@ -1518,6 +1518,13 @@ revert_internal(svn_wc__db_t *db,
}
/* Finally, recurse if requested. */
+
+ /* ### This doesn't work properly for added directories. Reverting
+ ### the parent before the children is wrong, it means node rows
+ ### exist for the children after the parent row is removed.
+ ### Either the wq revert of the parent above has to remove the
+ ### children or this recursion has to do children before parents.
+ */
if (!unversioned && db_kind == svn_wc__db_kind_dir && depth >
svn_depth_empty)
{
const apr_array_header_t *children;