Author: julianfoad
Date: Thu Nov 18 11:41:48 2010
New Revision: 1036419

URL: http://svn.apache.org/viewvc?rev=1036419&view=rev
Log:
Remove redundant svn_error_return() wrapper.

* subversion/svn/add-cmd.c,
  subversion/svn/changelist-cmd.c,
  subversion/svn/cleanup-cmd.c,
  subversion/svn/export-cmd.c,
  subversion/svn/import-cmd.c,
  subversion/svn/log-cmd.c,
  subversion/svn/patch-cmd.c,
  subversion/svn/resolve-cmd.c,
  subversion/svn/resolved-cmd.c,
  subversion/svn/revert-cmd.c,
  subversion/svn/status-cmd.c,
  subversion/svn/upgrade-cmd.c,
  subversion/libsvn_client/add.c,
  subversion/libsvn_client/changelist.c,
  subversion/libsvn_client/cleanup.c,
  subversion/libsvn_client/commit.c,
  subversion/libsvn_client/export.c,
  subversion/libsvn_client/log.c,
  subversion/libsvn_client/merge.c,
  subversion/libsvn_client/patch.c,
  subversion/libsvn_client/resolved.c,
  subversion/libsvn_client/revert.c,
  subversion/libsvn_client/status.c

  (svn_cl__add, svn_cl__changelist, svn_cl__cleanup, svn_cl__export,
   svn_cl__import, svn_cl__log, svn_cl__patch, svn_cl__resolve,
   svn_cl__resolved, svn_cl__revert, svn_cl__status, svn_cl__upgrade,
   svn_client_add4, svn_client_add_to_changelist,
   svn_client_remove_from_changelists, svn_client_cleanup,
   svn_client_commit5, svn_client_export5, svn_client_log5,
   svn_client_merge4, svn_client_patch, svn_client_resolve,
   svn_client_revert2, svn_client_status5):

    Remove redundant svn_error_return() wrapper. Also add blank line
    before/after 'if' block where ever required.

Patch by: Noorul Islam K M <noorul{_AT_}collab.net>

Modified:
    subversion/trunk/subversion/libsvn_client/add.c
    subversion/trunk/subversion/libsvn_client/changelist.c
    subversion/trunk/subversion/libsvn_client/cleanup.c
    subversion/trunk/subversion/libsvn_client/commit.c
    subversion/trunk/subversion/libsvn_client/export.c
    subversion/trunk/subversion/libsvn_client/log.c
    subversion/trunk/subversion/libsvn_client/merge.c
    subversion/trunk/subversion/libsvn_client/patch.c
    subversion/trunk/subversion/libsvn_client/resolved.c
    subversion/trunk/subversion/libsvn_client/revert.c
    subversion/trunk/subversion/libsvn_client/status.c
    subversion/trunk/subversion/svn/add-cmd.c
    subversion/trunk/subversion/svn/changelist-cmd.c
    subversion/trunk/subversion/svn/cleanup-cmd.c
    subversion/trunk/subversion/svn/export-cmd.c
    subversion/trunk/subversion/svn/import-cmd.c
    subversion/trunk/subversion/svn/log-cmd.c
    subversion/trunk/subversion/svn/patch-cmd.c
    subversion/trunk/subversion/svn/resolve-cmd.c
    subversion/trunk/subversion/svn/resolved-cmd.c
    subversion/trunk/subversion/svn/revert-cmd.c
    subversion/trunk/subversion/svn/status-cmd.c
    subversion/trunk/subversion/svn/upgrade-cmd.c

Modified: subversion/trunk/subversion/libsvn_client/add.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/add.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/add.c (original)
+++ subversion/trunk/subversion/libsvn_client/add.c Thu Nov 18 11:41:48 2010
@@ -576,9 +576,8 @@ svn_client_add4(const char *path,
   struct add_with_write_lock_baton baton;
 
   if (svn_path_is_url(path))
-    return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
-                                              _("'%s' is not a local path"),
-                                              path));
+    return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                             _("'%s' is not a local path"), path);
 
   SVN_ERR(svn_dirent_get_absolute(&local_abspath, path, pool));
 

Modified: subversion/trunk/subversion/libsvn_client/changelist.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/changelist.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/changelist.c (original)
+++ subversion/trunk/subversion/libsvn_client/changelist.c Thu Nov 18 11:41:48 
2010
@@ -114,11 +114,10 @@ svn_client_add_to_changelist(const apr_a
   for (i = 0; i < paths->nelts; i++)
     {
       const char *path = APR_ARRAY_IDX(paths, i, const char *);
+
       if (svn_path_is_url(path))
-        return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  path));
+        return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                                 _("'%s' is not a local path"), path);
     }
 
   if (changelists && changelists->nelts)
@@ -166,11 +165,10 @@ svn_client_remove_from_changelists(const
   for (i = 0; i < paths->nelts; i++)
     {
       const char *path = APR_ARRAY_IDX(paths, i, const char *);
+
       if (svn_path_is_url(path))
-        return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  path));
+        return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                                 _("'%s' is not a local path"), path);
     }
 
   if (changelists && changelists->nelts)

Modified: subversion/trunk/subversion/libsvn_client/cleanup.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/cleanup.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/cleanup.c (original)
+++ subversion/trunk/subversion/libsvn_client/cleanup.c Thu Nov 18 11:41:48 2010
@@ -52,9 +52,8 @@ svn_client_cleanup(const char *path,
   svn_error_t *err;
 
   if (svn_path_is_url(path))
-    return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
-                                              _("'%s' is not a local path"),
-                                              path));
+    return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                             _("'%s' is not a local path"), path);
 
   SVN_ERR(svn_dirent_get_absolute(&local_abspath, path, scratch_pool));
 
@@ -130,9 +129,8 @@ svn_client_upgrade(const char *path,
   info_baton.last_uuid = NULL;
 
   if (svn_path_is_url(path))
-    return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
-                                              _("'%s' is not a local path"),
-                                              path));
+    return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                             _("'%s' is not a local path"), path);
 
   SVN_ERR(svn_dirent_get_absolute(&local_abspath, path, scratch_pool));
   SVN_ERR(svn_wc_upgrade(ctx->wc_ctx, local_abspath,

Modified: subversion/trunk/subversion/libsvn_client/commit.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/commit.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/commit.c (original)
+++ subversion/trunk/subversion/libsvn_client/commit.c Thu Nov 18 11:41:48 2010
@@ -697,9 +697,8 @@ svn_client_import4(const char *path,
   apr_pool_t *subpool;
 
   if (svn_path_is_url(path))
-    return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
-                                              _("'%s' is not a local path"),
-                                              path));
+    return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                             _("'%s' is not a local path"), path);
 
   SVN_ERR(svn_dirent_get_absolute(&local_abspath, path, pool));
   base_dir_abspath = local_abspath;

Modified: subversion/trunk/subversion/libsvn_client/export.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/export.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/export.c (original)
+++ subversion/trunk/subversion/libsvn_client/export.c Thu Nov 18 11:41:48 2010
@@ -948,10 +948,9 @@ svn_client_export5(svn_revnum_t *result_
   SVN_ERR_ASSERT(revision != NULL);
 
   if (svn_path_is_url(to_path))
-    return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
-                                              _("'%s' is not a local path"),
-                                              to_path));
-    
+    return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                             _("'%s' is not a local path"), to_path);
+
   peg_revision = svn_cl__rev_default_to_head_or_working(peg_revision,
                                                         from_path_or_url);
   revision = svn_cl__rev_default_to_peg(revision, peg_revision);

Modified: subversion/trunk/subversion/libsvn_client/log.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/log.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/log.c (original)
+++ subversion/trunk/subversion/libsvn_client/log.c Thu Nov 18 11:41:48 2010
@@ -395,11 +395,12 @@ svn_client_log5(const apr_array_header_t
               const char *target;
 
               target = APR_ARRAY_IDX(targets, i, const char *);
+
               if (svn_path_is_url(target) || svn_dirent_is_absolute(target))
-                return svn_error_return(svn_error_createf(
-                                          SVN_ERR_ILLEGAL_TARGET, NULL,
-                                          _("'%s' is not a relative path"),
-                                          target));
+                return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                                         _("'%s' is not a relative path"),
+                                          target);
+
               APR_ARRAY_PUSH(condensed_targets, const char *) = target;
             }
         }

Modified: subversion/trunk/subversion/libsvn_client/merge.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/merge.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/merge.c (original)
+++ subversion/trunk/subversion/libsvn_client/merge.c Thu Nov 18 11:41:48 2010
@@ -8658,11 +8658,11 @@ do_merge(apr_hash_t **modified_subtrees,
 
   SVN_ERR(svn_wc_read_kind(&target_kind, ctx->wc_ctx, target_abspath, FALSE,
                            pool));
+
   if (target_kind != svn_node_dir && target_kind != svn_node_file)
-    return svn_error_return(svn_error_createf(
-                              SVN_ERR_ILLEGAL_TARGET, NULL,
-                              _("Merge target '%s' does not exist in the "
-                                "working copy"), target_abspath));
+    return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                             _("Merge target '%s' does not exist in the "
+                               "working copy"), target_abspath);
 
   /* Ensure a known depth. */
   if (depth == svn_depth_unknown)
@@ -9124,10 +9124,11 @@ merge_locked(const char *source1,
       || (revision2->kind == svn_opt_revision_unspecified))
     return svn_error_create(SVN_ERR_CLIENT_BAD_REVISION, NULL,
                             _("Not all required revisions are specified"));
+
   if (svn_path_is_url(source1) != svn_path_is_url(source2))
-    return svn_error_return(svn_error_create(SVN_ERR_ILLEGAL_TARGET, NULL,
-                                             _("Merge sources must both be "
-                                               "either paths or URLs")));
+    return svn_error_create(SVN_ERR_ILLEGAL_TARGET, NULL,
+                            _("Merge sources must both be "
+                              "either paths or URLs"));
 
   /* ### FIXME: This function really ought to do a history check on
      the left and right sides of the merge source, and -- if one is an
@@ -9157,12 +9158,11 @@ merge_locked(const char *source1,
 
   SVN_ERR(svn_wc_read_kind(&target_kind, ctx->wc_ctx, target_abspath, FALSE,
                            scratch_pool));
-  if (target_kind != svn_node_dir && target_kind != svn_node_file)
-    return svn_error_return(svn_error_createf(
-                              SVN_ERR_ILLEGAL_TARGET, NULL,
-                              _("Merge target '%s' does not exist in the "
-                                "working copy"), target_abspath));
 
+  if (target_kind != svn_node_dir && target_kind != svn_node_file)
+    return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                             _("Merge target '%s' does not exist in the "
+                               "working copy"), target_abspath);
 
   /* Do not allow merges into mixed-revision working copies. */
   SVN_ERR(ensure_wc_is_suitable_merge_target(target_abspath, ctx,

Modified: subversion/trunk/subversion/libsvn_client/patch.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/patch.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/patch.c (original)
+++ subversion/trunk/subversion/libsvn_client/patch.c Thu Nov 18 11:41:48 2010
@@ -2754,10 +2754,8 @@ svn_client_patch(const char *patch_abspa
                             _("strip count must be positive"));
 
   if (svn_path_is_url(local_abspath))
-    return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET,
-                                              NULL,
-                                              _("'%s' is not a local path"),
-                                              local_abspath));
+    return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                             _("'%s' is not a local path"), local_abspath);
 
   baton.patch_abspath = patch_abspath;
   baton.abs_wc_path = local_abspath;

Modified: subversion/trunk/subversion/libsvn_client/resolved.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/resolved.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/resolved.c (original)
+++ subversion/trunk/subversion/libsvn_client/resolved.c Thu Nov 18 11:41:48 
2010
@@ -50,9 +50,8 @@ svn_client_resolve(const char *path,
   const char *local_abspath;
 
   if (svn_path_is_url(path))
-    return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
-                                              _("'%s' is not a local path"),
-                                              path));
+    return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                             _("'%s' is not a local path"), path);
 
   SVN_ERR(svn_dirent_get_absolute(&local_abspath, path, pool));
 

Modified: subversion/trunk/subversion/libsvn_client/revert.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/revert.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/revert.c (original)
+++ subversion/trunk/subversion/libsvn_client/revert.c Thu Nov 18 11:41:48 2010
@@ -130,10 +130,8 @@ svn_client_revert2(const apr_array_heade
       const char *path = APR_ARRAY_IDX(paths, i, const char *);
 
       if (svn_path_is_url(path))
-        return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  path));
+        return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                                 _("'%s' is not a local path"), path);
     }
   
   cfg = ctx->config ? apr_hash_get(ctx->config, SVN_CONFIG_CATEGORY_CONFIG,

Modified: subversion/trunk/subversion/libsvn_client/status.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/status.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/status.c (original)
+++ subversion/trunk/subversion/libsvn_client/status.c Thu Nov 18 11:41:48 2010
@@ -270,9 +270,8 @@ svn_client_status5(svn_revnum_t *result_
   struct svn_client__external_func_baton_t externals_store = { NULL };
 
   if (svn_path_is_url(path))
-    return svn_error_return(svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
-                                              _("'%s' is not a local path"),
-                                              path));
+    return svn_error_createf(SVN_ERR_ILLEGAL_TARGET, NULL,
+                             _("'%s' is not a local path"), path);
 
   if (changelists && changelists->nelts)
     SVN_ERR(svn_hash_from_cstring_keys(&changelist_hash, changelists, pool));

Modified: subversion/trunk/subversion/svn/add-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/add-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/add-cmd.c (original)
+++ subversion/trunk/subversion/svn/add-cmd.c Thu Nov 18 11:41:48 2010
@@ -71,10 +71,8 @@ svn_cl__add(apr_getopt_t *os,
       const char *target = APR_ARRAY_IDX(targets, i, const char *);
 
       if (svn_path_is_url(target))
-        return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  target));
+        return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                                 _("'%s' is not a local path"), target);
     }
 
   iterpool = svn_pool_create(pool);

Modified: subversion/trunk/subversion/svn/changelist-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/changelist-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/changelist-cmd.c (original)
+++ subversion/trunk/subversion/svn/changelist-cmd.c Thu Nov 18 11:41:48 2010
@@ -76,10 +76,8 @@ svn_cl__changelist(apr_getopt_t *os,
       const char *target = APR_ARRAY_IDX(targets, i, const char *);
 
       if (svn_path_is_url(target))
-        return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  target));
+        return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                                 _("'%s' is not a local path"), target);
     }
 
   if (opt_state->quiet)

Modified: subversion/trunk/subversion/svn/cleanup-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/cleanup-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/cleanup-cmd.c (original)
+++ subversion/trunk/subversion/svn/cleanup-cmd.c Thu Nov 18 11:41:48 2010
@@ -64,10 +64,8 @@ svn_cl__cleanup(apr_getopt_t *os,
       const char *target = APR_ARRAY_IDX(targets, i, const char *);
 
       if (svn_path_is_url(target))
-        return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  target));
+        return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                                 _("'%s' is not a local path"), target);
     }
 
   SVN_ERR(svn_cl__eat_peg_revisions(&targets, targets, pool));

Modified: subversion/trunk/subversion/svn/export-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/export-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/export-cmd.c (original)
+++ subversion/trunk/subversion/svn/export-cmd.c Thu Nov 18 11:41:48 2010
@@ -86,10 +86,9 @@ svn_cl__export(apr_getopt_t *os,
     }
 
   if (svn_path_is_url(to))
-    return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                              NULL,
-                                              _("'%s' is not a local path"),
-                                              to));
+    return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                             _("'%s' is not a local path"), to);
+
   if (! opt_state->quiet)
     SVN_ERR(svn_cl__notifier_mark_export(ctx->notify_baton2));
 

Modified: subversion/trunk/subversion/svn/import-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/import-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/import-cmd.c (original)
+++ subversion/trunk/subversion/svn/import-cmd.c Thu Nov 18 11:41:48 2010
@@ -101,10 +101,9 @@ svn_cl__import(apr_getopt_t *os,
     }
 
   if (svn_path_is_url(path))
-    return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                              NULL,
-                                              _("'%s' is not a local path"),
-                                              path));
+    return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                             _("'%s' is not a local path"), path);
+
   if (! svn_path_is_url(url))
     return svn_error_createf
       (SVN_ERR_CL_ARG_PARSING_ERROR, NULL,

Modified: subversion/trunk/subversion/svn/log-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/log-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/log-cmd.c (original)
+++ subversion/trunk/subversion/svn/log-cmd.c Thu Nov 18 11:41:48 2010
@@ -647,12 +647,11 @@ svn_cl__log(apr_getopt_t *os,
           target = APR_ARRAY_IDX(targets, i, const char *);
 
           if (svn_path_is_url(target) || target[0] == '/')
-            return svn_error_return(svn_error_createf(
-                                      SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
-                                      _("Only relative paths can be specified"
-                                        " after a URL for 'svn log', "
-                                        "but '%s' is not a relative path"),
-                                      target));
+            return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                                     _("Only relative paths can be specified"
+                                       " after a URL for 'svn log', "
+                                       "but '%s' is not a relative path"),
+                                     target);
         }
     }
 

Modified: subversion/trunk/subversion/svn/patch-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/patch-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/patch-cmd.c (original)
+++ subversion/trunk/subversion/svn/patch-cmd.c Thu Nov 18 11:41:48 2010
@@ -66,11 +66,11 @@ svn_cl__patch(apr_getopt_t *os,
     return svn_error_create(SVN_ERR_CL_ARG_PARSING_ERROR, 0, NULL);
 
   patch_path = APR_ARRAY_IDX(targets, 0, const char *);
+
   if (svn_path_is_url(patch_path))
-    return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                              NULL,
-                                              _("'%s' is not a local path"),
-                                              patch_path));
+    return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                             _("'%s' is not a local path"), patch_path);
+
   SVN_ERR(svn_dirent_get_absolute(&abs_patch_path, patch_path, pool));
 
   if (targets->nelts == 1)
@@ -78,11 +78,10 @@ svn_cl__patch(apr_getopt_t *os,
   else
     {
       target_path = APR_ARRAY_IDX(targets, 1, const char *);
+
       if (svn_path_is_url(target_path))
-        return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  target_path));
+        return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                                 _("'%s' is not a local path"), target_path);
     }
   SVN_ERR(svn_dirent_get_absolute(&abs_target_path, target_path, pool));
 

Modified: subversion/trunk/subversion/svn/resolve-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/resolve-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/resolve-cmd.c (original)
+++ subversion/trunk/subversion/svn/resolve-cmd.c Thu Nov 18 11:41:48 2010
@@ -101,10 +101,8 @@ svn_cl__resolve(apr_getopt_t *os,
       const char *target = APR_ARRAY_IDX(targets, i, const char *);
 
       if (svn_path_is_url(target))
-        return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  target));
+        return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                                 _("'%s' is not a local path"), target);
     }
   
   iterpool = svn_pool_create(scratch_pool);

Modified: subversion/trunk/subversion/svn/resolved-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/resolved-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/resolved-cmd.c (original)
+++ subversion/trunk/subversion/svn/resolved-cmd.c Thu Nov 18 11:41:48 2010
@@ -71,10 +71,8 @@ svn_cl__resolved(apr_getopt_t *os,
       const char *target = APR_ARRAY_IDX(targets, i, const char *);
 
       if (svn_path_is_url(target))
-        return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  target));
+        return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                                 _("'%s' is not a local path"), target);
     }
   
   iterpool = svn_pool_create(scratch_pool);

Modified: subversion/trunk/subversion/svn/revert-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/revert-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/revert-cmd.c (original)
+++ subversion/trunk/subversion/svn/revert-cmd.c Thu Nov 18 11:41:48 2010
@@ -72,10 +72,8 @@ svn_cl__revert(apr_getopt_t *os,
       const char *target = APR_ARRAY_IDX(targets, i, const char *);
 
       if (svn_path_is_url(target))
-        return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  target));
+        return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                                 _("'%s' is not a local path"), target);
     }
 
   err = svn_client_revert2(targets, opt_state->depth,

Modified: subversion/trunk/subversion/svn/status-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/status-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/status-cmd.c (original)
+++ subversion/trunk/subversion/svn/status-cmd.c Thu Nov 18 11:41:48 2010
@@ -255,10 +255,8 @@ svn_cl__status(apr_getopt_t *os,
       const char *target = APR_ARRAY_IDX(targets, i, const char *);
 
       if (svn_path_is_url(target))
-        return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  target));
+        return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                                 _("'%s' is not a local path"), target);
     }
 
   /* We want our -u statuses to be against HEAD. */

Modified: subversion/trunk/subversion/svn/upgrade-cmd.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/upgrade-cmd.c?rev=1036419&r1=1036418&r2=1036419&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/upgrade-cmd.c (original)
+++ subversion/trunk/subversion/svn/upgrade-cmd.c Thu Nov 18 11:41:48 2010
@@ -67,10 +67,8 @@ svn_cl__upgrade(apr_getopt_t *os,
       const char *target = APR_ARRAY_IDX(targets, i, const char *);
 
       if (svn_path_is_url(target))
-        return svn_error_return(svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR,
-                                                  NULL,
-                                                  _("'%s' is not a local 
path"),
-                                                  target));
+        return svn_error_createf(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
+                                 _("'%s' is not a local path"), target);
     }
 
   iterpool = svn_pool_create(scratch_pool);


Reply via email to