Author: blair
Date: Wed Dec 29 01:59:23 2010
New Revision: 1053506
URL: http://svn.apache.org/viewvc?rev=1053506&view=rev
Log:
* STATUS: Nominate the 1.6.x-svn_fs_commit_txn branch.
Modified:
subversion/branches/1.6.x/STATUS
Modified: subversion/branches/1.6.x/STATUS
URL:
http://svn.apache.org/viewvc/subversion/branches/1.6.x/STATUS?rev=1053506&r1=1053505&r2=1053506&view=diff
==============================================================================
--- subversion/branches/1.6.x/STATUS (original)
+++ subversion/branches/1.6.x/STATUS Wed Dec 29 01:59:23 2010
@@ -192,6 +192,35 @@ Candidate changes:
Votes:
+1: blair
+ * 1.6.x-svn_fs_commit_txn branch
+ Have all of server-side Subversion, from svn_fs_commit_txn(),
+ through to mod_dav_svn, implement the documented (since 1.0.x)
+ behavior that svn_fs_commit_txn() and svn_repos_fs_commit_txn()
+ should indicate a successful commit by a valid returned revision
+ number, not by any returned error. Now, regardless if
+ svn_fs_commit_txn()'s post commit FS processing (that's its new
+ official name) fails, svn_repos_fs_commit_txn() will run the
+ post-commit hook. All code that uses svn_fs_commit_txn() and/or
+ svn_repos_fs_commit_txn() now uses the revision number to test if
+ the commit succeeded.
+ Justification:
+ Fixes bug reports on [email protected] where if post commit FS
+ processing fails, the client reports an error but the commit
+ succeeded, which is confusing for users.
+ Implementing the documented and correct behavior is a good thing.
+ Notes:
+ For a successful unit test pass, it requires that r1051632,
+ r1051638 and r1051751 listed above be merged previously.
+ The branch has many commits in it from trunk, which includes some
+ churn from reviews on trunk. I recommend reviewing a cumulative
+ diff:
+ svn diff -r r1053420:r1053500
^/subversion/branches/1.6.x-svn_fs_commit_txn
+ This merge doesn't address the client side behavior.
+ Branch:
+ ^/subversion/branches/1.6.x-svn_fs_commit_txn
+ Votes:
+ +1: blair
+
Veto-blocked changes:
=====================
