svn commit: r1101565 - /subversion/trunk/subversion/libsvn_client/cmdline.c

[philip]

Author: philip
Date: Tue May 10 17:55:29 2011
New Revision: 1101565

URL: http://svn.apache.org/viewvc?rev=1101565&view=rev
Log:
* subversion/libsvn_client/cmdline.c
  (svn_client_args_to_target_array): Note potential error leak.

Modified:
    subversion/trunk/subversion/libsvn_client/cmdline.c

Modified: subversion/trunk/subversion/libsvn_client/cmdline.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/cmdline.c?rev=1101565&r1=1101564&r2=1101565&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_client/cmdline.c (original)
+++ subversion/trunk/subversion/libsvn_client/cmdline.c Tue May 10 17:55:29 2011
@@ -267,6 +267,8 @@ svn_client_args_to_target_array(apr_arra
                                           err,
                                           _("'%s' ends in a reserved name"),
                                           utf8_target);
+
+                  /* ### Error leaks! Mixing SVN_ERR with err is a leak */
                   continue;
                 }
             }
@@ -275,6 +277,8 @@ svn_client_args_to_target_array(apr_arra
 
           if (rel_url_found)
             {
+              /* Later targets have priority over earlier target, I
+                 don't know why, see basic_relative_url_multi_repo. */
               SVN_ERR(check_root_url_of_target(&root_url, target,
                                                ctx, pool));
             }