Author: hwright
Date: Fri Aug 5 21:05:55 2011
New Revision: 1154381
URL: http://svn.apache.org/viewvc?rev=1154381&view=rev
Log:
On the fs-py branch:
Simplify a function by using a higher-level Python API.
* subversion/libsvn_fs_py/py_util.c
(create_py_stack): Use PyObject_CallMethod() to encapsulate some magic for us.
Modified:
subversion/branches/fs-py/subversion/libsvn_fs_py/py_util.c
Modified: subversion/branches/fs-py/subversion/libsvn_fs_py/py_util.c
URL:
http://svn.apache.org/viewvc/subversion/branches/fs-py/subversion/libsvn_fs_py/py_util.c?rev=1154381&r1=1154380&r2=1154381&view=diff
==============================================================================
--- subversion/branches/fs-py/subversion/libsvn_fs_py/py_util.c (original)
+++ subversion/branches/fs-py/subversion/libsvn_fs_py/py_util.c Fri Aug 5
21:05:55 2011
@@ -48,8 +48,6 @@ create_py_stack(PyObject *p_exception,
{
PyObject *p_module_name;
PyObject *p_traceback_mod;
- PyObject *p_func;
- PyObject *p_args;
PyObject *p_stack;
PyObject *p_frame;
PyObject *p_filename;
@@ -62,14 +60,10 @@ create_py_stack(PyObject *p_exception,
p_traceback_mod = PyImport_Import(p_module_name);
Py_DECREF(p_module_name);
- p_func = PyObject_GetAttrString(p_traceback_mod, "extract_tb");
+ p_stack = PyObject_CallMethod(p_traceback_mod, "extract_tb",
+ "(O)", p_traceback);
Py_DECREF(p_traceback_mod);
- p_args = Py_BuildValue("(O)", p_traceback);
- p_stack = PyObject_CallObject(p_func, p_args);
- Py_DECREF(p_func);
- Py_DECREF(p_args);
-
i = PySequence_Length(p_stack);
/* Build the "root error" for the chain. */
