Author: danielsh
Date: Tue Aug 9 12:33:34 2011
New Revision: 1155334
URL: http://svn.apache.org/viewvc?rev=1155334&view=rev
Log:
ctypes: Following up on r1155044 and r1155313, let Python take care of
destroying the repository object. This is cleaner and also tests that
garbage collection works properly.
* subversion/bindings/ctypes-python/test/remoterepos.py
(RemoteRepositoryTestCase.setUp):
Don't explicitly close() the repository; instead, rely on...
* subversion/bindings/ctypes-python/csvn/repos.py
(__del__):
... this new method.
Modified:
subversion/trunk/subversion/bindings/ctypes-python/csvn/repos.py
subversion/trunk/subversion/bindings/ctypes-python/test/remoterepos.py
Modified: subversion/trunk/subversion/bindings/ctypes-python/csvn/repos.py
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/ctypes-python/csvn/repos.py?rev=1155334&r1=1155333&r2=1155334&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/ctypes-python/csvn/repos.py (original)
+++ subversion/trunk/subversion/bindings/ctypes-python/csvn/repos.py Tue Aug 9
12:33:34 2011
@@ -400,6 +400,9 @@ class LocalRepository(object):
svn_repos_open(byref(self._as_parameter_), path, self.pool)
self.fs = _fs(self)
+ def __del__(self):
+ self.close()
+
def close(self):
"""Close this LocalRepository object, releasing any resources. In
particular, this closes the rep-cache DB."""
Modified: subversion/trunk/subversion/bindings/ctypes-python/test/remoterepos.py
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/ctypes-python/test/remoterepos.py?rev=1155334&r1=1155333&r2=1155334&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/ctypes-python/test/remoterepos.py
(original)
+++ subversion/trunk/subversion/bindings/ctypes-python/test/remoterepos.py Tue
Aug 9 12:33:34 2011
@@ -51,7 +51,6 @@ class RemoteRepositoryTestCase(unittest.
self.repos = LocalRepository(repos_location, create=True)
self.repos.load(dumpfile)
- self.repos.close()
self.repos = RemoteRepository(repos_url)
