Author: danielsh
Date: Fri Sep 23 05:33:59 2011
New Revision: 1174526
URL: http://svn.apache.org/viewvc?rev=1174526&view=rev
Log:
Extend a test to cover the false negative that svn_spillbuf__is_empty() had.
* subversion/tests/libsvn_subr/spillbuf-test.c
(test_spillbuf_interleaving): Test some svn_spillbuff__get_size() calls.
(The last one tests for the bug; the former ones are for good measure.)
Modified:
subversion/trunk/subversion/tests/libsvn_subr/spillbuf-test.c
Modified: subversion/trunk/subversion/tests/libsvn_subr/spillbuf-test.c
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_subr/spillbuf-test.c?rev=1174526&r1=1174525&r2=1174526&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_subr/spillbuf-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_subr/spillbuf-test.c Fri Sep 23
05:33:59 2011
@@ -224,18 +224,22 @@ test_spillbuf_interleaving(apr_pool_t *p
SVN_ERR(svn_spillbuf__write(buf, "GHIJKL", 6, pool));
/* now: two blocks of 8 and 6 bytes, and 6 bytes spilled to a file */
+ SVN_TEST_ASSERT(svn_spillbuf__get_size(buf) > 0);
SVN_ERR(svn_spillbuf__read(&readptr, &readlen, buf, pool));
SVN_TEST_ASSERT(readptr != NULL
&& readlen == 8
&& memcmp(readptr, "qrstuvwx", 8) == 0);
+ SVN_TEST_ASSERT(svn_spillbuf__get_size(buf) > 0);
SVN_ERR(svn_spillbuf__read(&readptr, &readlen, buf, pool));
SVN_TEST_ASSERT(readptr != NULL
&& readlen == 6
&& memcmp(readptr, "ABCDEF", 6) == 0);
+ SVN_TEST_ASSERT(svn_spillbuf__get_size(buf) > 0);
SVN_ERR(svn_spillbuf__read(&readptr, &readlen, buf, pool));
SVN_TEST_ASSERT(readptr != NULL
&& readlen == 6
&& memcmp(readptr, "GHIJKL", 6) == 0);
+ SVN_TEST_ASSERT(svn_spillbuf__get_size(buf) == 0);
return SVN_NO_ERROR;
}
