Author: breser
Revision: 1404736
Modified property: svn:log
Modified: svn:log at Thu Nov 22 02:18:06 2012
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Thu Nov 22 02:18:06 2012
@@ -3,9 +3,18 @@ when an error occurs.
This is similar to changes that happened sometime prior to 1.7.
-This creates problems for the r1403964 fix since the transaction gets
-deleted before the pool gets cleaned up and thus we're executing our
-cleanup in the wrong order.
+At the time of committing this I thought this caused problems for r1403964.
+However, on further review this simply ensures that the rep_write_cleanup()
+is called before any call to the abort_edit() on the editor which would
+purge the transaction. The reversal of these calls would have made the
+unlocking of the transaction fail (without this change). But that would have
+created no problems and the error goes nowhere because the pool destroy/cleanup
+functions return a void.
+
+As such this change ensures slight more correct operation, but is not
+absolutely necessary. It does have the added benefit of cleaning up a
+potential memory leak when a user of the client library is not passing
+pools to our commit functions that they cleanup afterwards.
* subversion/libsvn_client/commit_util.c
(svn_client__do_commit): In case of errors from svn_wc_adm_retrieve() or
