Author: breser
Date: Fri Dec 21 00:34:31 2012
New Revision: 1424775

URL: http://svn.apache.org/viewvc?rev=1424775&view=rev
Log:
Resolve a bug in svnpubsub commit hook when there is no author.

The existing code ran strip before splitting, which would have
removed the leading blank line indicating no author.

* tools/server-side/svnpubsub/commit-hook.py
  (svncmd_info): strip individual fields after splitting.

Modified:
    subversion/trunk/tools/server-side/svnpubsub/commit-hook.py

Modified: subversion/trunk/tools/server-side/svnpubsub/commit-hook.py
URL: 
http://svn.apache.org/viewvc/subversion/trunk/tools/server-side/svnpubsub/commit-hook.py?rev=1424775&r1=1424774&r2=1424775&view=diff
==============================================================================
--- subversion/trunk/tools/server-side/svnpubsub/commit-hook.py (original)
+++ subversion/trunk/tools/server-side/svnpubsub/commit-hook.py Fri Dec 21 
00:34:31 2012
@@ -42,11 +42,11 @@ def svncmd_uuid(repo):
 def svncmd_info(repo, revision):
     cmd = "%s info -r %s %s" % (SVNLOOK, revision, repo)
     p = svncmd(cmd)
-    data = p.stdout.read().strip().split("\n")
+    data = p.stdout.read().split("\n")
     #print data
-    return {'author': data[0],
-            'date': data[1],
-            'log': "\n".join(data[3:])}
+    return {'author': data[0].strip(),
+            'date': data[1].strip(),
+            'log': "\n".join(data[3:]).strip()}
 
 def svncmd_dirs(repo, revision):
     cmd = "%s dirs-changed  -r %s %s" % (SVNLOOK, revision, repo)


Reply via email to