svn commit: r1431068 - in /subversion/trunk/subversion/bindings/javahl/native: JNIUtil.cpp RevpropTable.cpp SVNClient.cpp

[philip]

Author: philip
Date: Wed Jan  9 20:59:33 2013
New Revision: 1431068

URL: http://svn.apache.org/viewvc?rev=1431068&view=rev
Log:
Avoid some compiler warnings in JavaHL.

* subversion/bindings/javahl/native/SVNClient.cpp
  (SVNClient::SVNClient): Initialise members in the order they are defined.

* subversion/bindings/javahl/native/RevpropTable.cpp
  (RevpropTable::RevpropTable): Remove unused variable.

* subversion/bindings/javahl/native/JNIUtil.cpp
  (JNIUtil::putErrorsInTrace): Parentheses around assigment used as condition.

Modified:
    subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp
    subversion/trunk/subversion/bindings/javahl/native/RevpropTable.cpp
    subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp

Modified: subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp?rev=1431068&r1=1431067&r2=1431068&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp (original)
+++ subversion/trunk/subversion/bindings/javahl/native/JNIUtil.cpp Wed Jan  9 
20:59:33 2013
@@ -396,7 +396,7 @@ JNIUtil::putErrorsInTrace(svn_error_t *e
 
   char *tmp_path;
   char *path = svn_dirent_dirname(err->file, err->pool);
-  while (tmp_path = strchr(path, '/'))
+  while ((tmp_path = strchr(path, '/')))
     *tmp_path = '.';
 
   jstring jmethodName = makeJString(path);

Modified: subversion/trunk/subversion/bindings/javahl/native/RevpropTable.cpp
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/native/RevpropTable.cpp?rev=1431068&r1=1431067&r2=1431068&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/native/RevpropTable.cpp 
(original)
+++ subversion/trunk/subversion/bindings/javahl/native/RevpropTable.cpp Wed Jan 
 9 20:59:33 2013
@@ -77,7 +77,7 @@ RevpropTable::RevpropTable(jobject jrevp
 
   if (jrevpropTable != NULL)
     {
-      static jmethodID keySet = 0, toArray = 0, get = 0;
+      static jmethodID keySet = 0, get = 0;
       JNIEnv *env = JNIUtil::getEnv();
 
       jclass mapClazz = env->FindClass("java/util/Map");

Modified: subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp?rev=1431068&r1=1431067&r2=1431068&view=diff
==============================================================================
--- subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp (original)
+++ subversion/trunk/subversion/bindings/javahl/native/SVNClient.cpp Wed Jan  9 
20:59:33 2013
@@ -71,7 +71,7 @@
 
 
 SVNClient::SVNClient(jobject jthis_in)
-    : context(jthis_in, pool), m_lastPath("", pool)
+    : m_lastPath("", pool), context(jthis_in, pool)
 {
 }