Author: danielsh
Date: Fri Apr 12 19:58:55 2013
New Revision: 1467440
URL: http://svn.apache.org/r1467440
Log:
Make maintainer-mode stack traces less cluttered.
Suggested by: cmpilato
* subversion/libsvn_subr/error.c
(print_error): Print a placeholder sometimes, and note in a comment that
assumptions we thereby make about our caller.
Modified:
subversion/trunk/subversion/libsvn_subr/error.c
Modified: subversion/trunk/subversion/libsvn_subr/error.c
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/error.c?rev=1467440&r1=1467439&r2=1467440&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/error.c (original)
+++ subversion/trunk/subversion/libsvn_subr/error.c Fri Apr 12 19:58:55 2013
@@ -454,6 +454,8 @@ svn_error_purge_tracing(svn_error_t *err
#endif /* SVN_ERR__TRACING */
}
+/* ### The logic around printing "_" in maintainer mode is very tightly
+ ### coupled to the current sole caller.*/
static void
print_error(svn_error_t *err, FILE *stream, const char *prefix)
{
@@ -482,7 +484,12 @@ print_error(svn_error_t *err, FILE *stre
}
{
- const char *symbolic_name = svn_error_symbolic_name(err->apr_err);
+ const char *symbolic_name;
+ if (svn_error__is_tracing_link(err))
+ symbolic_name = "_";
+ else
+ symbolic_name = svn_error_symbolic_name(err->apr_err);
+
if (symbolic_name)
svn_error_clear(svn_cmdline_fprintf(stream, err->pool,
": (apr_err=%s)\n", symbolic_name));
