Author: stefan2
Date: Thu May 16 20:44:37 2013
New Revision: 1483557

URL: http://svn.apache.org/r1483557
Log:
Fix an off-by-one issue when comparing property names.  If I'm not mistaken,
the old code should consider "svn:date123" equivalent to "svn:date".

Due to our namespace rules, this should not turn into a real-world problem
but it is still a bug.

* subversion/libsvn_repos/fs-wrap.c
  (svn_repos_fs_revision_prop): compare the whole string - not just a prefix

Modified:
    subversion/trunk/subversion/libsvn_repos/fs-wrap.c

Modified: subversion/trunk/subversion/libsvn_repos/fs-wrap.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/fs-wrap.c?rev=1483557&r1=1483556&r2=1483557&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/fs-wrap.c (original)
+++ subversion/trunk/subversion/libsvn_repos/fs-wrap.c Thu May 16 20:44:37 2013
@@ -410,10 +410,8 @@ svn_repos_fs_revision_prop(svn_string_t 
   else if (readability == svn_repos_revision_access_partial)
     {
       /* Only svn:author and svn:date are fetchable. */
-      if ((strncmp(propname, SVN_PROP_REVISION_AUTHOR,
-                   sizeof(SVN_PROP_REVISION_AUTHOR)-1) != 0)
-          && (strncmp(propname, SVN_PROP_REVISION_DATE,
-                      sizeof(SVN_PROP_REVISION_DATE)-1) != 0))
+      if ((strcmp(propname, SVN_PROP_REVISION_AUTHOR) != 0)
+          && (strcmp(propname, SVN_PROP_REVISION_DATE) != 0))
         *value_p = NULL;
 
       else


Reply via email to