Author: cmpilato
Date: Tue May 21 20:22:58 2013
New Revision: 1484938
URL: http://svn.apache.org/r1484938
Log:
On the 'auth-notification' branch: Remove a notification action and
the handling thereof. The system isn't quite behaving as I'd expected.
* subversion/libsvn_subr/auth.c
(svn_auth_save_credentials): Don't use svn_auth_notify_creds_validated.
* subversion/include/svn_auth.h
(svn_auth_notify_creds_validated): Remove enum value. While in the
area, add some docs.
* subversion/svn/svn.c
(auth_notify): Drop handling of svn_auth_notify_creds_validated.
Modified:
subversion/branches/auth-notification/subversion/include/svn_auth.h
subversion/branches/auth-notification/subversion/libsvn_subr/auth.c
subversion/branches/auth-notification/subversion/svn/svn.c
Modified: subversion/branches/auth-notification/subversion/include/svn_auth.h
URL:
http://svn.apache.org/viewvc/subversion/branches/auth-notification/subversion/include/svn_auth.h?rev=1484938&r1=1484937&r2=1484938&view=diff
==============================================================================
--- subversion/branches/auth-notification/subversion/include/svn_auth.h
(original)
+++ subversion/branches/auth-notification/subversion/include/svn_auth.h Tue May
21 20:22:58 2013
@@ -95,8 +95,10 @@ typedef struct svn_auth_iterstate_t svn_
*/
typedef enum svn_auth_notify_action_t
{
+ /** @brief Credentials were acquired (from provider). */
svn_auth_notify_creds_acquired = 0,
- svn_auth_notify_creds_validated,
+
+ /** @brief Credentials were stored (by provider). */
svn_auth_notify_creds_stored
} svn_auth_notify_action_t;
Modified: subversion/branches/auth-notification/subversion/libsvn_subr/auth.c
URL:
http://svn.apache.org/viewvc/subversion/branches/auth-notification/subversion/libsvn_subr/auth.c?rev=1484938&r1=1484937&r2=1484938&view=diff
==============================================================================
--- subversion/branches/auth-notification/subversion/libsvn_subr/auth.c
(original)
+++ subversion/branches/auth-notification/subversion/libsvn_subr/auth.c Tue May
21 20:22:58 2013
@@ -388,13 +388,6 @@ svn_auth_save_credentials(svn_auth_iters
auth_notify_baton = svn_hash_gets(auth_baton->parameters,
SVN_AUTH_PARAM_NOTIFY_BATON);
- if (auth_notify_func)
- {
- SVN_ERR(auth_notify_func(auth_notify_baton,
- svn_auth_notify_creds_validated,
- NULL, pool));
- }
-
/* Do not save the creds if SVN_AUTH_PARAM_NO_AUTH_CACHE is set */
no_auth_cache = svn_hash_gets(auth_baton->parameters,
SVN_AUTH_PARAM_NO_AUTH_CACHE);
Modified: subversion/branches/auth-notification/subversion/svn/svn.c
URL:
http://svn.apache.org/viewvc/subversion/branches/auth-notification/subversion/svn/svn.c?rev=1484938&r1=1484937&r2=1484938&view=diff
==============================================================================
--- subversion/branches/auth-notification/subversion/svn/svn.c (original)
+++ subversion/branches/auth-notification/subversion/svn/svn.c Tue May 21
20:22:58 2013
@@ -1672,11 +1672,6 @@ auth_notify(void *baton,
provider_name);
/* not reached */
- case svn_auth_notify_creds_validated:
- return svn_cmdline_fputs(_("Credentials validated\n"),
- stderr, scratch_pool);
- /* not reached */
-
case svn_auth_notify_creds_stored:
return svn_cmdline_fprintf(stderr, scratch_pool,
_("Credentials stored (%s)\n"),
