On 27.05.2013 06:41, Daniel Shahaf wrote:
> On Sun, May 26, 2013 at 09:22:48PM +0000, Daniel Shahaf wrote:
>> On Sun, May 26, 2013 at 08:06:47PM -0000, [email protected] wrote:
>>> +def main(repo, revision, author, propname, action):
>>> +    else:
>>> +        sys.stderr.write('Unknown revprop change action "%s"\n' % action)
>>> +        return
>> Maybe sys.exit(1)?  Otherwise the stderr output will likely go unnoticed
>> (libsvn_repos discards stderr when the exit code is zero).
> You haven't s/return/sys.exit(1)/ here.  Do you disagree with that change?

Ah, I just missed it. It was kind of late.

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com

Reply via email to