Author: danielsh
Date: Tue May 28 08:17:34 2013
New Revision: 1486809

URL: http://svn.apache.org/r1486809
Log:
svnpubsub: fix MIME type declaration.  Reincarnation of r1486775.

application/json is wrong: it is not appropriate for a sequence of
NUL-terminated JSON objects.

[in tools/server-side/svnpubsub]
* svnpubsub/server.py
  (Client.write_start): Use application/octet-stream.  Leave a comment about
    exploring better options.

Modified:
    subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py

Modified: subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py
URL: 
http://svn.apache.org/viewvc/subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py?rev=1486809&r1=1486808&r2=1486809&view=diff
==============================================================================
--- subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py (original)
+++ subversion/trunk/tools/server-side/svnpubsub/svnpubsub/server.py Tue May 28 
08:17:34 2013
@@ -183,7 +183,10 @@ class Client(object):
         self.r.write(str(input))
 
     def write_start(self):
-        self.r.setHeader('content-type', 'application/json')
+        # TODO: use application/x-* or vnd.* - see 
+        # Message-ID: 
<CADkdwvR=hwwevz+xn2hdild-hbpiz7q5fqafq_f5+m77zg6...@mail.gmail.com>
+        # on May 2013
+        self.r.setHeader('content-type', 'application/octet-stream')
         self.write('{"svnpubsub": {"version": 1}}\n\0')
 
     def write_heartbeat(self):


Reply via email to