Author: philip
Date: Fri Dec  6 10:41:27 2013
New Revision: 1548486

URL: http://svn.apache.org/r1548486
Log:
* subversion/libsvn_subr/io.c
  (contents_three_identical_p): Fixed incorrect pointer check against NULL,
   when the purpose was actually to check the value stored at that pointer
   for true or false. There is no change in the output of the function but
   it avoids some disk IO.

Patch by: eric{_AT_}lubin.us

Modified:
    subversion/trunk/subversion/libsvn_subr/io.c

Modified: subversion/trunk/subversion/libsvn_subr/io.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/io.c?rev=1548486&r1=1548485&r2=1548486&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/io.c (original)
+++ subversion/trunk/subversion/libsvn_subr/io.c Fri Dec  6 10:41:27 2013
@@ -4614,7 +4614,7 @@ contents_three_identical_p(svn_boolean_t
 
       /* As long as a file is not at the end yet, and it is still
        * potentially identical to another file, we read the next chunk.*/
-      if (!eof1 && (identical_p12 || identical_p13))
+      if (!eof1 && (*identical_p12 || *identical_p13))
         {
           err = svn_io_file_read_full2(file1_h, buf1,
                                    SVN__STREAM_CHUNK_SIZE, &bytes_read1,
@@ -4624,7 +4624,7 @@ contents_three_identical_p(svn_boolean_t
           read_1 = TRUE;
         }
 
-      if (!eof2 && (identical_p12 || identical_p23))
+      if (!eof2 && (*identical_p12 || *identical_p23))
         {
           err = svn_io_file_read_full2(file2_h, buf2,
                                    SVN__STREAM_CHUNK_SIZE, &bytes_read2,
@@ -4634,7 +4634,7 @@ contents_three_identical_p(svn_boolean_t
           read_2 = TRUE;
         }
 
-      if (!eof3 && (identical_p13 || identical_p23))
+      if (!eof3 && (*identical_p13 || *identical_p23))
         {
           err = svn_io_file_read_full2(file3_h, buf3,
                                    SVN__STREAM_CHUNK_SIZE, &bytes_read3,


Reply via email to