Author: stefan2
Date: Tue Aug 19 13:02:28 2014
New Revision: 1618856

URL: http://svn.apache.org/r1618856
Log:
Remove the now unused svn__strtol.

* subversion/include/private/svn_string_private.h
  (svn__strtol): Remove private API.

* subversion/include/svn_types.h
  (SVN_STR_TO_REV): Don't mention the removed function in the docstring.

* subversion/libsvn_subr/string.c
  (svn__strtol): Remove implementation.

Modified:
    subversion/trunk/subversion/include/private/svn_string_private.h
    subversion/trunk/subversion/include/svn_types.h
    subversion/trunk/subversion/libsvn_subr/string.c

Modified: subversion/trunk/subversion/include/private/svn_string_private.h
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_string_private.h?rev=1618856&r1=1618855&r2=1618856&view=diff
==============================================================================
--- subversion/trunk/subversion/include/private/svn_string_private.h (original)
+++ subversion/trunk/subversion/include/private/svn_string_private.h Tue Aug 19 
13:02:28 2014
@@ -139,13 +139,6 @@ svn_stringbuf__morph_into_string(svn_str
 unsigned long
 svn__strtoul(const char *buffer, const char **end);
 
-/** Like strtol but with a fixed base of 10 and without overflow checks.
- * This allows the compiler to generate massively faster code.
- * (E.g. Avoiding locale specific processing)
- */
-long
-svn__strtol(const char *buffer, const char **end);
-
 /** Number of chars needed to represent signed (19 places + sign + NUL) or
  * unsigned (20 places + NUL) integers as strings.
  */

Modified: subversion/trunk/subversion/include/svn_types.h
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_types.h?rev=1618856&r1=1618855&r2=1618856&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_types.h (original)
+++ subversion/trunk/subversion/include/svn_types.h Tue Aug 19 13:02:28 2014
@@ -433,8 +433,6 @@ typedef long int svn_revnum_t;
 #define SVN_IGNORED_REVNUM ((svn_revnum_t) -1)
 
 /** Convert NULL-terminated C string @a str to a revision number. */
-/* When in a hot path, consider using svn__strtol() instead; atol() may be
-   locale-aware and thus slower. */
 #define SVN_STR_TO_REV(str) ((svn_revnum_t) atol(str))
 
 /**

Modified: subversion/trunk/subversion/libsvn_subr/string.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/string.c?rev=1618856&r1=1618855&r2=1618856&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/string.c (original)
+++ subversion/trunk/subversion/libsvn_subr/string.c Tue Aug 19 13:02:28 2014
@@ -1068,16 +1068,6 @@ svn__strtoul(const char* buffer, const c
   return result;
 }
 
-long
-svn__strtol(const char* buffer, const char** end)
-{
-  if (*buffer == '-')
-    return -(long)svn__strtoul(buffer+1, end);
-  else
-    return (long)svn__strtoul(buffer, end);
-}
-
-
 /* "Precalculated" itoa values for 2 places (including leading zeros).
  * For maximum performance, make sure all table entries are word-aligned.
  */


Reply via email to