Author: rhuijben
Date: Sun Feb 15 18:12:50 2015
New Revision: 1659962
URL: http://svn.apache.org/r1659962
Log:
* subversion/svn/util.c
(svn_cl__print_commit_info): Add comment.
Modified:
subversion/trunk/subversion/svn/util.c
Modified: subversion/trunk/subversion/svn/util.c
URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/util.c?rev=1659962&r1=1659961&r2=1659962&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/util.c (original)
+++ subversion/trunk/subversion/svn/util.c Sun Feb 15 18:12:50 2015
@@ -75,6 +75,13 @@ svn_cl__print_commit_info(const svn_comm
void *baton,
apr_pool_t *pool)
{
+ /* Be very careful with returning errors from this callback as those
+ will be returned as errors from editor->close_edit(...), which may
+ cause callers to assume that the commit itself failed.
+
+ See log message of r1659867 and the svn_ra_get_commit_editor3
+ documentation for details on error scenarios. */
+
if (SVN_IS_VALID_REVNUM(commit_info->revision))
SVN_ERR(svn_cmdline_printf(pool, _("Committed revision %ld%s.\n"),
commit_info->revision,
