Dear Wiki user, You have subscribed to a wiki page or wiki category on "Subversion Wiki" for change notification.
The "Svn19ApiReview" page has been changed by StefanFuhrmann: https://wiki.apache.org/subversion/Svn19ApiReview?action=diff&rev1=16&rev2=17 Comment: Various headers have been completed. ---- == Reviewed But Need Further Attention == - === svn_client.h === - New functions: - - * `svn_client_vacuum` — Missing documentation for arguments `fix_recorded_timestamps` and `vacuum_pristines`. (svn praise: r1548088 rhuijben) - - === svn_diff.h === - * `svn_diff_output2` - * `svn_diff_file_output_unified4` - * `svn_diff_output_binary` - * `svn_diff_file_output_merge3` - * `svn_diff_mem_string_output_unified3` - * `svn_diff_mem_string_output_merge3` — Document the optional cancel_func & cancel_baton. It may be helpful to tell when they will be invoked (once per file / hunk?). - === svn_dirent_uri.h === * `svn_relpath_limit` — Is this really a good public API, either in functionality or in name? I suggest it should be a local function in the one file where it's used, or else made private and named `svn_relpath__first_n_components`. - - === svn_fs.h === - * `svn_fs_commit_txn` — Is the `SVN_FS_TXN_CLIENT_DATE` behavior still as described? Yes. Do we want to mention here that this is a 1.9 extension? SVN_FS_TXN_CLIENT_DATE is marked new in 1.9. - * `svn_fs_lock_target_create` — `pool` parameter: Is this a `result_pool` or should it even become 2 pools?Renamed result_pool. - * `svn_fs_lock_callback_t` — `pool` parameter: Maybe rename to `scratch_pool`. Renamed scratch_pool. - * `svn_fs_lock_many`, `svn_fs_unlock_many` — Mention in docstring that these are not atomic operations. If the callback returns an error, they simply return that error to their callers and leave part of the locks in their initial and the remainder in the final state. What is the lock error handling in case of `lock_callback==NULL`?Doc updated. - * `svn_fs_unlock_many` — What is the `result_pool` being used for? As for svn_fs_lock_many, it it used to allocate the result data passed to the callback. === svn_ra_svn.h === * `svn_ra_svn_create_conn4` — The @note is unclear. Is the file being used for time-out detection? @@ -60, +40 @@ ---- == Review Completed! == + All issues found so far have been resolved for these headers: + + . svn_client.h + . svn_diff.h + . svn_fs.h + These headers have been reviewed by stefan2 and where issues have been found, they are already fixed. More review is welcome. . mod_dav_svn.h
