Author: danielsh
Date: Sun Aug  6 22:35:17 2017
New Revision: 1804278

URL: http://svn.apache.org/viewvc?rev=1804278&view=rev
Log:
release.py: Don't discard errors.

* tools/dist/release.py
  (run_script): Don't discard stderr in non-verbose mode.

* tools/dist/dist.sh: Use 'set -e' to ensure errors fail noisily.

Modified:
    subversion/trunk/tools/dist/dist.sh
    subversion/trunk/tools/dist/release.py

Modified: subversion/trunk/tools/dist/dist.sh
URL: 
http://svn.apache.org/viewvc/subversion/trunk/tools/dist/dist.sh?rev=1804278&r1=1804277&r2=1804278&view=diff
==============================================================================
--- subversion/trunk/tools/dist/dist.sh (original)
+++ subversion/trunk/tools/dist/dist.sh Sun Aug  6 22:35:17 2017
@@ -57,6 +57,7 @@
 #   To build a Windows zip file package, additionally pass -zip and the
 #   path to apr-iconv with -apri.
 
+set -e
 
 USAGE="USAGE: ./dist.sh -v VERSION -r REVISION -pr REPOS-PATH \
 [-alpha ALPHA_NUM|-beta BETA_NUM|-rc RC_NUM|-pre PRE_NUM] \

Modified: subversion/trunk/tools/dist/release.py
URL: 
http://svn.apache.org/viewvc/subversion/trunk/tools/dist/release.py?rev=1804278&r1=1804277&r2=1804278&view=diff
==============================================================================
--- subversion/trunk/tools/dist/release.py (original)
+++ subversion/trunk/tools/dist/release.py Sun Aug  6 22:35:17 2017
@@ -246,13 +246,11 @@ def get_nullfile():
 def run_script(verbose, script):
     if verbose:
         stdout = None
-        stderr = None
     else:
         stdout = get_nullfile()
-        stderr = subprocess.STDOUT
 
     for l in script.split('\n'):
-        subprocess.check_call(l.split(), stdout=stdout, stderr=stderr)
+        subprocess.check_call(l.split(), stdout=stdout)
 
 def download_file(url, target, checksum):
     response = urllib2.urlopen(url)


Reply via email to