Author: kotkov
Date: Sat Nov 25 19:54:09 2017
New Revision: 1816344

URL: http://svn.apache.org/viewvc?rev=1816344&view=rev
Log:
* subversion/libsvn_fs_fs/low_level.c
  (svn_fs_fs__parse_representation): Note a potentially unexpected side
   effect of this function, as currently it modifies the input string.

Modified:
    subversion/trunk/subversion/libsvn_fs_fs/low_level.c

Modified: subversion/trunk/subversion/libsvn_fs_fs/low_level.c
URL: 
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/low_level.c?rev=1816344&r1=1816343&r2=1816344&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_fs/low_level.c (original)
+++ subversion/trunk/subversion/libsvn_fs_fs/low_level.c Sat Nov 25 19:54:09 
2017
@@ -741,6 +741,9 @@ read_header_block(apr_hash_t **headers,
   return SVN_NO_ERROR;
 }
 
+/* ### Ouch!  The implementation of this function currently modifies
+   ### the input string when tokenizing it (so the input cannot be
+   ### used after that). */
 svn_error_t *
 svn_fs_fs__parse_representation(representation_t **rep_p,
                                 svn_stringbuf_t *text,


Reply via email to