Author: danielsh
Date: Sat Feb 10 19:39:06 2018
New Revision: 1823793
URL: http://svn.apache.org/viewvc?rev=1823793&view=rev
Log:
* tools/dist/backport.pl
(vote): Do not access the ->{vote} member when it might be undefined.
Fixes 'Use of uninitialized value in hash element at ./b line 793' when
committing an approval that's not accompanied by a vote, e.g., r1823790.
Modified:
subversion/trunk/tools/dist/backport.pl
Modified: subversion/trunk/tools/dist/backport.pl
URL:
http://svn.apache.org/viewvc/subversion/trunk/tools/dist/backport.pl?rev=1823793&r1=1823792&r2=1823793&view=diff
==============================================================================
--- subversion/trunk/tools/dist/backport.pl (original)
+++ subversion/trunk/tools/dist/backport.pl Sat Feb 10 19:39:06 2018
@@ -791,7 +791,7 @@ sub vote {
# Add to state votes that aren't '+0' or 'edit'
$state->{$_->{digest}}++ for grep
- +{ qw/-1 t -0 t +1 t/ }->{$_->{vote}},
+ ($_->{approval} or $_->{vote} =~
/^(-1|-0|[+]1)$/),
@votesarray;
}
}