Author: stsp
Date: Mon Feb 12 12:09:30 2018
New Revision: 1823952

URL: http://svn.apache.org/viewvc?rev=1823952&view=rev
Log:
Revert r1823787. For an unknown reason it caused segfaults and
bus errors in httpd worker processes on the svn-bb-openbsd bot.

Modified:
    subversion/trunk/tools/dev/unix-build/Makefile.svn

Modified: subversion/trunk/tools/dev/unix-build/Makefile.svn
URL: 
http://svn.apache.org/viewvc/subversion/trunk/tools/dev/unix-build/Makefile.svn?rev=1823952&r1=1823951&r2=1823952&view=diff
==============================================================================
--- subversion/trunk/tools/dev/unix-build/Makefile.svn (original)
+++ subversion/trunk/tools/dev/unix-build/Makefile.svn Mon Feb 12 12:09:30 2018
@@ -1958,9 +1958,17 @@ endif
 libpath:
        @echo export LD_LIBRARY_PATH="$(LD_LIBRARY_PATH):$$LD_LIBRARY_PATH" \
                "PYTHONPATH=$(SVN_PREFIX)/lib/svn-python"
+#
+# OpenBSD requires an LD_PRELOAD hack to dlopen() libraries linked to
+# libpthread (e.g. libsvn_auth_gnome_keyring.so) into executables that
+# aren't linked to libpthread.
+ifeq ($(UNAME),OpenBSD)
+LIB_PTHREAD_HACK=LD_PRELOAD=libpthread.so
+endif
+
 .PHONY: start-svnserve stop-svnserve start-httpd stop-httpd
 
-HTTPD_CMD = env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) \
+HTTPD_CMD = env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) $(LIB_PTHREAD_HACK) \
                $(PREFIX)/httpd/bin/apachectl
 HTTPD_LOG_ROTATE = mv $(PREFIX)/httpd/logs/error_log 
$(PREFIX)/httpd/logs/error_log.old
 HTTPD_START_CMD = $(HTTPD_CMD) -f $(HTTPD_CHECK_CONF) -k start
@@ -2019,7 +2027,7 @@ define do_check
 -cd $(svn_builddir) && for fs in fsfs bdb; do \
     echo "Begin test: $(subst svn-check-,,$@) x $$fs"; \
     test -d "$(RAMDISK)/tmp" && export TMPDIR="$(RAMDISK)/tmp"; \
-    env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) \
+    env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) $(LIB_PTHREAD_HACK) \
         env MAKEFLAGS= make check PARALLEL=$(PARALLEL) CLEANUP=$(CLEANUP) \
          EXCLUSIVE_WC_LOCKS=$(EXCLUSIVE_WC_LOCKS) \
          SVN_BIN_DIR=$(SVN_PREFIX)/bin \
@@ -2078,6 +2086,7 @@ svn-check-swig-pl:
        -if [ $(ENABLE_PERL_BINDINGS) = yes ]; then \
                (cd $(svn_builddir) && \
                        env LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) \
+                       $(LIB_PTHREAD_HACK) \
                        env MAKEFLAGS= make check-swig-pl 2>&1) | \
                                tee $(svn_builddir)/tests.log.bindings.pl; \
        fi
@@ -2095,7 +2104,8 @@ svn-check-swig-rb:
                env RUBYLIB=$(RUBYLIB) \
                LD_LIBRARY_PATH=$(LD_LIBRARY_PATH) \
                PATH=$(SVN_PREFIX)/bin:$$PATH \
-               MAKEFLAGS= make check-swig-rb 2>&1) | \
+               $(LIB_PTHREAD_HACK) \
+                       env MAKEFLAGS= make check-swig-rb 2>&1) | \
                        tee $(svn_builddir)/tests.log.bindings.rb
 
 svn-check-javahl:


Reply via email to