On 2024/07/11 15:38:21 [email protected] wrote:
> Author: rinrab
> Date: Thu Jul 11 15:38:21 2024
> New Revision: 1919150
>
> URL: http://svn.apache.org/viewvc?rev=1919150&view=rev
> Log:
> On the 'cmake' branch: Support RA-Serf and add Serf dependency.
[...]
> +### Serf
> +if (SVN_BUILD_RA_SERF)
> + find_package(Serf REQUIRED)
> + add_library(external-serf ALIAS Serf::Serf)
> +endif()
> +
[...]
> +message(STATUS " Build RA SERF ................. : ${SVN_BUILD_RA_SERF}")
[...]
> +message(STATUS " SERF .......................... : ${Serf_VERSION}")
How about enclosing the last message (${Serf_VERSION}) inside an if
(SVN_ENABLE_RA_SERF), like this:
[[[
if (SVN_ENABLE_RA_SERF)
message(STATUS " SERF .......................... : ${Serf_VERSION}")
endif()
]]]
Currently the configuration summary output is
[[[
-- Enable RA SERF ................ : OFF
-- Dependecies:
-- SERF .......................... :
]]]
With the above change it will only be:
[[[
-- Enable RA SERF ................ : OFF
-- Dependecies:
]]]
With SVN_ENABLE_RA_SERF the output is (in any case):
[[[
-- Enable RA SERF ................ : ON
-- Dependecies:
-- SERF .......................... : 1.3.10
]]]
I don't see a reason for listing Serf (with an empty version string) under
Dependencies if it is not used.
Another option would be to set the Serf_VERSION string to something reasonable
if SVN_ENABLE_RA_SERF is OFF, output could be something like below, but think
it is less clear.
[[[
-- Enable RA SERF ................ : OFF
-- Dependecies:
-- SERF .......................... : None
]]]
Kind regards,
Daniel
