svn commit: r1934786 - subversion/trunk/subversion/libsvn_fs_x

[brane]

Author: brane
Date: Sat May 30 20:18:05 2026
New Revision: 1934786

Log:
Fix an uninitialized memory access bug in FSX.

[-Wuninitialized-const-pointer] by clang-2100.1.1.101 on macOS.

* subversion/libsvn_fs_x/revprops.c
  (repack_file_open): Do not copy random stack contents to the manifest array.

Modified:
   subversion/trunk/subversion/libsvn_fs_x/revprops.c

Modified: subversion/trunk/subversion/libsvn_fs_x/revprops.c
==============================================================================
--- subversion/trunk/subversion/libsvn_fs_x/revprops.c  Sat May 30 19:00:13 
2026        (r1934785)
+++ subversion/trunk/subversion/libsvn_fs_x/revprops.c  Sat May 30 20:18:05 
2026        (r1934786)
@@ -1203,7 +1203,7 @@ repack_file_open(apr_file_t **file,
   if (revprops->entry.start_rev == start_rev)
     APR_ARRAY_IDX(revprops->manifest, idx, manifest_entry_t) = new_entry;
   else
-    SVN_ERR(svn_sort__array_insert2(revprops->manifest, &new_path, idx + 1));
+    SVN_ERR(svn_sort__array_insert2(revprops->manifest, &new_entry, idx + 1));
 
   /* open the file */
   new_path = get_revprop_pack_filepath(revprops, &new_entry, scratch_pool);