[incubator-superset] branch master updated: fix: Database API missing allow none on fields (#10795)

[dpgaspar]

This is an automated email from the ASF dual-hosted git repository.

dpgaspar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 782f678  fix: Database API missing allow none on fields (#10795)
782f678 is described below

commit 782f678732be43de67f6d225e944856c5dcd7b18
Author: Daniel Vaz Gaspar <danielvazgas...@gmail.com>
AuthorDate: Wed Sep 9 09:35:27 2020 +0100

    fix: Database API missing allow none on fields (#10795)
    
    * fix: Database API missing allow none on fields
    
    * one missing
---
 superset/databases/schemas.py | 32 ++++++++++++++++++++++++--------
 1 file changed, 24 insertions(+), 8 deletions(-)

diff --git a/superset/databases/schemas.py b/superset/databases/schemas.py
index a6a182f..2d6779d 100644
--- a/superset/databases/schemas.py
+++ b/superset/databases/schemas.py
@@ -215,7 +215,9 @@ class DatabasePostSchema(Schema):
     database_name = fields.String(
         description=database_name_description, required=True, 
validate=Length(1, 250),
     )
-    cache_timeout = fields.Integer(description=cache_timeout_description)
+    cache_timeout = fields.Integer(
+        description=cache_timeout_description, allow_none=True
+    )
     expose_in_sqllab = fields.Boolean(description=expose_in_sqllab_description)
     allow_run_async = fields.Boolean(description=allow_run_async_description)
     allow_csv_upload = fields.Boolean(description=allow_csv_upload_description)
@@ -223,18 +225,24 @@ class DatabasePostSchema(Schema):
     allow_cvas = fields.Boolean(description=allow_cvas_description)
     allow_dml = fields.Boolean(description=allow_dml_description)
     force_ctas_schema = fields.String(
-        description=force_ctas_schema_description, validate=Length(0, 250)
+        description=force_ctas_schema_description,
+        allow_none=True,
+        validate=Length(0, 250),
     )
     allow_multi_schema_metadata_fetch = fields.Boolean(
         description=allow_multi_schema_metadata_fetch_description,
     )
     impersonate_user = fields.Boolean(description=impersonate_user_description)
     encrypted_extra = fields.String(
-        description=encrypted_extra_description, 
validate=encrypted_extra_validator
+        description=encrypted_extra_description,
+        validate=encrypted_extra_validator,
+        allow_none=True,
     )
     extra = fields.String(description=extra_description, 
validate=extra_validator)
     server_cert = fields.String(
-        description=server_cert_description, validate=server_cert_validator
+        description=server_cert_description,
+        allow_none=True,
+        validate=server_cert_validator,
     )
     sqlalchemy_uri = fields.String(
         description=sqlalchemy_uri_description,
@@ -247,7 +255,9 @@ class DatabasePutSchema(Schema):
     database_name = fields.String(
         description=database_name_description, allow_none=True, 
validate=Length(1, 250),
     )
-    cache_timeout = fields.Integer(description=cache_timeout_description)
+    cache_timeout = fields.Integer(
+        description=cache_timeout_description, allow_none=True
+    )
     expose_in_sqllab = fields.Boolean(description=expose_in_sqllab_description)
     allow_run_async = fields.Boolean(description=allow_run_async_description)
     allow_csv_upload = fields.Boolean(description=allow_csv_upload_description)
@@ -255,18 +265,24 @@ class DatabasePutSchema(Schema):
     allow_cvas = fields.Boolean(description=allow_cvas_description)
     allow_dml = fields.Boolean(description=allow_dml_description)
     force_ctas_schema = fields.String(
-        description=force_ctas_schema_description, validate=Length(0, 250)
+        description=force_ctas_schema_description,
+        allow_none=True,
+        validate=Length(0, 250),
     )
     allow_multi_schema_metadata_fetch = fields.Boolean(
         description=allow_multi_schema_metadata_fetch_description
     )
     impersonate_user = fields.Boolean(description=impersonate_user_description)
     encrypted_extra = fields.String(
-        description=encrypted_extra_description, 
validate=encrypted_extra_validator
+        description=encrypted_extra_description,
+        allow_none=True,
+        validate=encrypted_extra_validator,
     )
     extra = fields.String(description=extra_description, 
validate=extra_validator)
     server_cert = fields.String(
-        description=server_cert_description, validate=server_cert_validator
+        description=server_cert_description,
+        allow_none=True,
+        validate=server_cert_validator,
     )
     sqlalchemy_uri = fields.String(
         description=sqlalchemy_uri_description,