This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new c5193ca Re-enable rule no-non-null-assertion (#10864)
c5193ca is described below
commit c5193ca01870ab088fc460a3a487a4791c6cc042
Author: Kamil Gabryjelski <[email protected]>
AuthorDate: Mon Sep 14 19:40:20 2020 +0200
Re-enable rule no-non-null-assertion (#10864)
---
superset-frontend/.eslintrc.js | 1 -
superset-frontend/src/components/FilterableTable/FilterableTable.tsx | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js
index 27c1bcc..30abc8c 100644
--- a/superset-frontend/.eslintrc.js
+++ b/superset-frontend/.eslintrc.js
@@ -59,7 +59,6 @@ module.exports = {
'@typescript-eslint/ban-types': 0, // disabled temporarily
'@typescript-eslint/no-empty-function': 0,
'@typescript-eslint/no-explicit-any': 0,
- '@typescript-eslint/no-non-null-assertion': 0, // disabled temporarily
'@typescript-eslint/no-use-before-define': 1, // disabled temporarily
'@typescript-eslint/no-unused-vars': 0, // disabled temporarily
'@typescript-eslint/explicit-function-return-type': 0,
diff --git
a/superset-frontend/src/components/FilterableTable/FilterableTable.tsx
b/superset-frontend/src/components/FilterableTable/FilterableTable.tsx
index 34b44e7..d320b0c 100644
--- a/superset-frontend/src/components/FilterableTable/FilterableTable.tsx
+++ b/superset-frontend/src/components/FilterableTable/FilterableTable.tsx
@@ -289,7 +289,7 @@ export default class FilterableTable extends PureComponent<
}
fitTableToWidthIfNeeded() {
- const containerWidth = this.container.current!.clientWidth;
+ const containerWidth = this.container.current?.clientWidth ?? 0;
if (this.totalTableWidth < containerWidth) {
// fit table width if content doesn't fill the width of the container
this.totalTableWidth = containerWidth;