This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 9f01a7f ESLint: Re-enable rule default-props-match-prop-types (#10868)
9f01a7f is described below
commit 9f01a7fdf8dd834c9aaa04cfe06d512ead6a19ef
Author: Kamil Gabryjelski <[email protected]>
AuthorDate: Tue Sep 22 22:17:41 2020 +0200
ESLint: Re-enable rule default-props-match-prop-types (#10868)
* Re-enable rule default-props-match-prop-types
* Restore default props and remove isRequired
* Remove unused props
---
superset-frontend/.eslintrc.js | 2 --
.../dashboard/components/DashboardBuilder_spec.jsx | 3 ---
superset-frontend/src/CRUD/Field.jsx | 3 +--
.../src/SqlLab/components/ExploreCtasResultsButton.jsx | 5 -----
.../src/SqlLab/components/SqlEditorLeftBar.jsx | 2 +-
.../src/SqlLab/components/TemplateParamsEditor.jsx | 2 --
superset-frontend/src/components/Hotkeys.jsx | 5 -----
.../src/components/Select/OnPasteSelect.jsx | 6 +++---
.../dashboard/components/ColorSchemeControlWrapper.jsx | 4 ++--
.../src/dashboard/components/DashboardBuilder.jsx | 17 +----------------
.../src/dashboard/components/PropertiesModal.jsx | 2 +-
.../src/dashboard/components/SliceAdder.jsx | 2 +-
.../src/dashboard/components/SliceHeader.jsx | 1 -
.../src/dashboard/components/gridComponents/Row.jsx | 5 -----
.../src/dashboard/components/gridComponents/Tabs.jsx | 1 -
.../src/dashboard/components/menu/WithPopoverMenu.jsx | 1 -
.../src/dashboard/containers/DashboardBuilder.jsx | 4 ----
.../src/dashboard/containers/DashboardComponent.jsx | 1 -
.../src/explore/components/QueryAndSaveBtns.jsx | 1 -
.../explore/components/controls/ColorSchemeControl.jsx | 4 ++--
.../src/explore/components/controls/ViewportControl.jsx | 2 +-
21 files changed, 13 insertions(+), 60 deletions(-)
diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js
index 1d5c492..ed437f9 100644
--- a/superset-frontend/.eslintrc.js
+++ b/superset-frontend/.eslintrc.js
@@ -117,7 +117,6 @@ module.exports = {
'padded-blocks': 0,
'prefer-arrow-callback': 0,
'prefer-destructuring': ['error', { object: true, array: false }],
- 'react/default-props-match-prop-types': 0, // disabled temporarily
'react/destructuring-assignment': 0, // re-enable up for discussion
'react/forbid-prop-types': 0,
'react/jsx-filename-extension': [1, { extensions: ['.jsx', '.tsx'] }],
@@ -228,7 +227,6 @@ module.exports = {
'prefer-arrow-callback': 0,
'prefer-object-spread': 1,
'prefer-destructuring': ['error', { object: true, array: false }],
- 'react/default-props-match-prop-types': 0, // disabled temporarily
'react/destructuring-assignment': 0, // re-enable up for discussion
'react/forbid-prop-types': 0,
'react/jsx-filename-extension': [1, { extensions: ['.jsx', '.tsx'] }],
diff --git
a/superset-frontend/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx
b/superset-frontend/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx
index 82211c4..5de2135 100644
---
a/superset-frontend/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx
+++
b/superset-frontend/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx
@@ -62,9 +62,6 @@ describe('DashboardBuilder', () => {
dashboardLayout,
deleteTopLevelTabs() {},
editMode: false,
- showBuilderPane() {},
- setColorSchemeAndUnsavedChanges() {},
- colorScheme: undefined,
handleComponentDrop() {},
setDirectPathToChild: sinon.spy(),
};
diff --git a/superset-frontend/src/CRUD/Field.jsx
b/superset-frontend/src/CRUD/Field.jsx
index 3d56019..3ed439f 100644
--- a/superset-frontend/src/CRUD/Field.jsx
+++ b/superset-frontend/src/CRUD/Field.jsx
@@ -39,10 +39,9 @@ const propTypes = {
compact: PropTypes.bool,
};
const defaultProps = {
- controlProps: {},
onChange: () => {},
compact: false,
- desc: null,
+ description: null,
};
export default class Field extends React.PureComponent {
diff --git
a/superset-frontend/src/SqlLab/components/ExploreCtasResultsButton.jsx
b/superset-frontend/src/SqlLab/components/ExploreCtasResultsButton.jsx
index 0fac3d1..3c3e203 100644
--- a/superset-frontend/src/SqlLab/components/ExploreCtasResultsButton.jsx
+++ b/superset-frontend/src/SqlLab/components/ExploreCtasResultsButton.jsx
@@ -37,10 +37,6 @@ const propTypes = {
templateParams: PropTypes.string,
};
-const defaultProps = {
- vizRequest: {},
-};
-
class ExploreCtasResultsButton extends React.PureComponent {
constructor(props) {
super(props);
@@ -113,7 +109,6 @@ class ExploreCtasResultsButton extends React.PureComponent {
}
}
ExploreCtasResultsButton.propTypes = propTypes;
-ExploreCtasResultsButton.defaultProps = defaultProps;
function mapStateToProps({ sqlLab, common }) {
return {
diff --git a/superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
b/superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
index 552ba4c..66a5385 100644
--- a/superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
+++ b/superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
@@ -25,7 +25,7 @@ import TableSelector from '../../components/TableSelector';
const propTypes = {
queryEditor: PropTypes.object.isRequired,
- height: PropTypes.number.isRequired,
+ height: PropTypes.number,
tables: PropTypes.array,
actions: PropTypes.object,
database: PropTypes.object,
diff --git a/superset-frontend/src/SqlLab/components/TemplateParamsEditor.jsx
b/superset-frontend/src/SqlLab/components/TemplateParamsEditor.jsx
index a15f563..4552576 100644
--- a/superset-frontend/src/SqlLab/components/TemplateParamsEditor.jsx
+++ b/superset-frontend/src/SqlLab/components/TemplateParamsEditor.jsx
@@ -33,8 +33,6 @@ const propTypes = {
};
const defaultProps = {
- label: null,
- description: null,
onChange: () => {},
code: '{}',
};
diff --git a/superset-frontend/src/components/Hotkeys.jsx
b/superset-frontend/src/components/Hotkeys.jsx
index c0d4707..546d3ed 100644
--- a/superset-frontend/src/components/Hotkeys.jsx
+++ b/superset-frontend/src/components/Hotkeys.jsx
@@ -33,10 +33,6 @@ const propTypes = {
placement: PropTypes.string,
};
-const defaultProps = {
- hotkeys: [],
-};
-
export default class Hotkeys extends React.PureComponent {
componentDidMount() {
this.props.hotkeys.forEach(keyConfig => {
@@ -86,4 +82,3 @@ export default class Hotkeys extends React.PureComponent {
}
Hotkeys.propTypes = propTypes;
-Hotkeys.defaultProps = defaultProps;
diff --git a/superset-frontend/src/components/Select/OnPasteSelect.jsx
b/superset-frontend/src/components/Select/OnPasteSelect.jsx
index fcf1e10..e7d08ae 100644
--- a/superset-frontend/src/components/Select/OnPasteSelect.jsx
+++ b/superset-frontend/src/components/Select/OnPasteSelect.jsx
@@ -81,12 +81,12 @@ export default class OnPasteSelect extends React.Component {
}
OnPasteSelect.propTypes = {
- separator: PropTypes.array.isRequired,
+ separator: PropTypes.array,
selectWrap: PropTypes.elementType,
selectRef: PropTypes.func,
onChange: PropTypes.func.isRequired,
- valueKey: PropTypes.string.isRequired,
- labelKey: PropTypes.string.isRequired,
+ valueKey: PropTypes.string,
+ labelKey: PropTypes.string,
options: PropTypes.array,
isMulti: PropTypes.bool,
value: PropTypes.any,
diff --git
a/superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
b/superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
index b2e14d1..d607946 100644
--- a/superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
+++ b/superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
@@ -24,13 +24,13 @@ import { getCategoricalSchemeRegistry, t } from
'@superset-ui/core';
import ColorSchemeControl from
'src/explore/components/controls/ColorSchemeControl';
const propTypes = {
- onChange: PropTypes.func.isRequired,
+ onChange: PropTypes.func,
colorScheme: PropTypes.string,
};
const defaultProps = {
- colorScheme: undefined,
onChange: () => {},
+ colorScheme: undefined,
};
class ColorSchemeControlWrapper extends React.PureComponent {
diff --git a/superset-frontend/src/dashboard/components/DashboardBuilder.jsx
b/superset-frontend/src/dashboard/components/DashboardBuilder.jsx
index ecaf3cf..3f798c1 100644
--- a/superset-frontend/src/dashboard/components/DashboardBuilder.jsx
+++ b/superset-frontend/src/dashboard/components/DashboardBuilder.jsx
@@ -54,9 +54,6 @@ const propTypes = {
dashboardLayout: PropTypes.object.isRequired,
deleteTopLevelTabs: PropTypes.func.isRequired,
editMode: PropTypes.bool.isRequired,
- showBuilderPane: PropTypes.func.isRequired,
- colorScheme: PropTypes.string,
- setColorSchemeAndUnsavedChanges: PropTypes.func.isRequired,
handleComponentDrop: PropTypes.func.isRequired,
directPathToChild: PropTypes.arrayOf(PropTypes.string),
setDirectPathToChild: PropTypes.func.isRequired,
@@ -64,9 +61,7 @@ const propTypes = {
};
const defaultProps = {
- showBuilderPane: false,
directPathToChild: [],
- colorScheme: undefined,
};
class DashboardBuilder extends React.Component {
@@ -155,14 +150,7 @@ class DashboardBuilder extends React.Component {
}
render() {
- const {
- handleComponentDrop,
- dashboardLayout,
- editMode,
- showBuilderPane,
- setColorSchemeAndUnsavedChanges,
- colorScheme,
- } = this.props;
+ const { handleComponentDrop, dashboardLayout, editMode } = this.props;
const { tabIndex } = this.state;
const dashboardRoot = dashboardLayout[DASHBOARD_ROOT_ID];
const rootChildId = dashboardRoot.children[0];
@@ -272,9 +260,6 @@ class DashboardBuilder extends React.Component {
{editMode && (
<BuilderComponentPane
topOffset={HEADER_HEIGHT + (topLevelTabs ? TABS_HEIGHT : 0)}
- showBuilderPane={showBuilderPane}
- setColorSchemeAndUnsavedChanges={setColorSchemeAndUnsavedChanges}
- colorScheme={colorScheme}
/>
)}
</div>
diff --git a/superset-frontend/src/dashboard/components/PropertiesModal.jsx
b/superset-frontend/src/dashboard/components/PropertiesModal.jsx
index 57f3482..2637f51 100644
--- a/superset-frontend/src/dashboard/components/PropertiesModal.jsx
+++ b/superset-frontend/src/dashboard/components/PropertiesModal.jsx
@@ -35,7 +35,7 @@ import '../stylesheets/buttons.less';
const propTypes = {
dashboardId: PropTypes.number.isRequired,
- show: PropTypes.bool.isRequired,
+ show: PropTypes.bool,
onHide: PropTypes.func,
colorScheme: PropTypes.object,
setColorSchemeAndUnsavedChanges: PropTypes.func,
diff --git a/superset-frontend/src/dashboard/components/SliceAdder.jsx
b/superset-frontend/src/dashboard/components/SliceAdder.jsx
index 9034a81..80d80cb 100644
--- a/superset-frontend/src/dashboard/components/SliceAdder.jsx
+++ b/superset-frontend/src/dashboard/components/SliceAdder.jsx
@@ -39,7 +39,7 @@ const propTypes = {
lastUpdated: PropTypes.number.isRequired,
errorMessage: PropTypes.string,
userId: PropTypes.string.isRequired,
- selectedSliceIds: PropTypes.arrayOf(PropTypes.number).isRequired,
+ selectedSliceIds: PropTypes.arrayOf(PropTypes.number),
editMode: PropTypes.bool,
height: PropTypes.number,
};
diff --git a/superset-frontend/src/dashboard/components/SliceHeader.jsx
b/superset-frontend/src/dashboard/components/SliceHeader.jsx
index 941c0ad..276d36a 100644
--- a/superset-frontend/src/dashboard/components/SliceHeader.jsx
+++ b/superset-frontend/src/dashboard/components/SliceHeader.jsx
@@ -53,7 +53,6 @@ const propTypes = {
const defaultProps = {
innerRef: null,
forceRefresh: () => ({}),
- removeSlice: () => ({}),
updateSliceName: () => ({}),
toggleExpandSlice: () => ({}),
exploreChart: () => ({}),
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
b/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
index f9076bc..f98cac9 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
@@ -56,10 +56,6 @@ const propTypes = {
updateComponents: PropTypes.func.isRequired,
};
-const defaultProps = {
- rowHeight: null,
-};
-
class Row extends React.PureComponent {
constructor(props) {
super(props);
@@ -192,6 +188,5 @@ class Row extends React.PureComponent {
}
Row.propTypes = propTypes;
-Row.defaultProps = defaultProps;
export default Row;
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
b/superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
index b765cbf..1765ebb 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
@@ -69,7 +69,6 @@ const propTypes = {
};
const defaultProps = {
- children: null,
renderTabContent: true,
renderHoverMenu: true,
availableColumnCount: 0,
diff --git
a/superset-frontend/src/dashboard/components/menu/WithPopoverMenu.jsx
b/superset-frontend/src/dashboard/components/menu/WithPopoverMenu.jsx
index 42158dc..eb43901 100644
--- a/superset-frontend/src/dashboard/components/menu/WithPopoverMenu.jsx
+++ b/superset-frontend/src/dashboard/components/menu/WithPopoverMenu.jsx
@@ -35,7 +35,6 @@ const defaultProps = {
children: null,
disableClick: false,
onChangeFocus: null,
- onPressDelete() {},
menuItems: [],
isFocused: false,
shouldFocus: (event, container) =>
diff --git a/superset-frontend/src/dashboard/containers/DashboardBuilder.jsx
b/superset-frontend/src/dashboard/containers/DashboardBuilder.jsx
index dacdb7b..9d06e77 100644
--- a/superset-frontend/src/dashboard/containers/DashboardBuilder.jsx
+++ b/superset-frontend/src/dashboard/containers/DashboardBuilder.jsx
@@ -21,7 +21,6 @@ import { connect } from 'react-redux';
import DashboardBuilder from '../components/DashboardBuilder';
import {
- setColorSchemeAndUnsavedChanges,
showBuilderPane,
setDirectPathToChild,
setMountedTab,
@@ -35,9 +34,7 @@ function mapStateToProps({ dashboardLayout: undoableLayout,
dashboardState }) {
return {
dashboardLayout: undoableLayout.present,
editMode: dashboardState.editMode,
- showBuilderPane: dashboardState.showBuilderPane,
directPathToChild: dashboardState.directPathToChild,
- colorScheme: dashboardState.colorScheme,
};
}
@@ -47,7 +44,6 @@ function mapDispatchToProps(dispatch) {
deleteTopLevelTabs,
handleComponentDrop,
showBuilderPane,
- setColorSchemeAndUnsavedChanges,
setDirectPathToChild,
setMountedTab,
},
diff --git a/superset-frontend/src/dashboard/containers/DashboardComponent.jsx
b/superset-frontend/src/dashboard/containers/DashboardComponent.jsx
index d4a403f..aaa7da3 100644
--- a/superset-frontend/src/dashboard/containers/DashboardComponent.jsx
+++ b/superset-frontend/src/dashboard/containers/DashboardComponent.jsx
@@ -53,7 +53,6 @@ const propTypes = {
const defaultProps = {
directPathToChild: [],
directPathLastUpdated: 0,
- isComponentVisible: true,
};
function mapStateToProps(
diff --git a/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
b/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
index e233484..9eaec3c 100644
--- a/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
+++ b/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
@@ -37,7 +37,6 @@ const propTypes = {
const defaultProps = {
onStop: () => {},
onSave: () => {},
- disabled: false,
};
// Prolly need to move this to a global context
diff --git
a/superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
b/superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
index 4b9d6e4..0d3a56e 100644
--- a/superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
+++ b/superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
@@ -35,8 +35,8 @@ const propTypes = {
choices: PropTypes.oneOfType([
PropTypes.arrayOf(PropTypes.array),
PropTypes.func,
- ]).isRequired,
- schemes: PropTypes.oneOfType([PropTypes.object, PropTypes.func]).isRequired,
+ ]),
+ schemes: PropTypes.oneOfType([PropTypes.object, PropTypes.func]),
isLinear: PropTypes.bool,
};
diff --git
a/superset-frontend/src/explore/components/controls/ViewportControl.jsx
b/superset-frontend/src/explore/components/controls/ViewportControl.jsx
index 9aa6be1..11731b1 100644
--- a/superset-frontend/src/explore/components/controls/ViewportControl.jsx
+++ b/superset-frontend/src/explore/components/controls/ViewportControl.jsx
@@ -37,7 +37,7 @@ export const DEFAULT_VIEWPORT = {
const PARAMS = ['longitude', 'latitude', 'zoom', 'bearing', 'pitch'];
const propTypes = {
- onChange: PropTypes.func.isRequired,
+ onChange: PropTypes.func,
value: PropTypes.shape({
longitude: PropTypes.number,
latitude: PropTypes.number,
