This is an automated email from the ASF dual-hosted git repository.
villebro pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 2a4ca9f fix(crud): set default extra value (#11262)
2a4ca9f is described below
commit 2a4ca9fa98c2fe841809f2019ab62a9f7708ad10
Author: Ville Brofeldt <[email protected]>
AuthorDate: Wed Oct 14 19:05:20 2020 +0300
fix(crud): set default extra value (#11262)
---
superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
index 54e8a8c..681e7e6 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
@@ -125,6 +125,9 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
const [isHidden, setIsHidden] = useState<boolean>(true);
const isEditMode = database !== null;
+ const defaultExtra =
+ '{\n "metadata_params": {},\n "engine_params": {},' +
+ '\n "metadata_cache_timeout": {},\n "schemas_allowed_for_csv_upload": []
\n}';
// Database fetch logic
const {
@@ -588,11 +591,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
<div className="input-container">
<textarea
name="extra"
- value={db ? db.extra || '' : ''}
- placeholder={
- '{\n "metadata_params": {},\n "engine_params": {},' +
- '\n "metadata_cache_timeout": {},\n
"schemas_allowed_for_csv_upload": [] \n}'
- }
+ value={(db && db.extra) ?? defaultExtra}
onChange={onTextChange}
/>
</div>
