This is an automated email from the ASF dual-hosted git repository.
yjc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 4af7264 fix: make higher chart box resizable (#11673)
4af7264 is described below
commit 4af7264a2c70e16363fd68b903306e2a9c7f92b4
Author: Kasia Kucharczyk <[email protected]>
AuthorDate: Thu Nov 12 20:53:48 2020 +0100
fix: make higher chart box resizable (#11673)
* Added visible resizible icon to all types of blocks in tabs
* Adjusted position of hovered framwes and edited markdown
---
.../src/dashboard/components/DashboardBuilder.jsx | 2 +-
.../src/dashboard/stylesheets/components/markdown.less | 8 --------
superset-frontend/src/dashboard/stylesheets/dnd.less | 10 ++++++++++
superset-frontend/src/dashboard/stylesheets/popover-menu.less | 6 +++---
4 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/DashboardBuilder.jsx
b/superset-frontend/src/dashboard/components/DashboardBuilder.jsx
index d9da824..86b2d62 100644
--- a/superset-frontend/src/dashboard/components/DashboardBuilder.jsx
+++ b/superset-frontend/src/dashboard/components/DashboardBuilder.jsx
@@ -93,7 +93,7 @@ const StyledDashboardContent = styled.div`
transition: opacity ${({ theme }) => theme.transitionTiming}s,
border-color ${({ theme }) => theme.transitionTiming}s,
box-shadow ${({ theme }) => theme.transitionTiming}s;
- border: ${({ theme }) => theme.gridUnit / 2}px solid transparent;
+ border: 0px solid transparent;
}
`;
diff --git
a/superset-frontend/src/dashboard/stylesheets/components/markdown.less
b/superset-frontend/src/dashboard/stylesheets/components/markdown.less
index 9b0704c..1f7b2ae 100644
--- a/superset-frontend/src/dashboard/stylesheets/components/markdown.less
+++ b/superset-frontend/src/dashboard/stylesheets/components/markdown.less
@@ -45,14 +45,6 @@
#brace-editor {
border: none;
}
-
- .resizable-container {
- span {
- div {
- z-index: @z-index-above-dashboard-charts;
- }
- }
- }
}
/* maximize editing space */
diff --git a/superset-frontend/src/dashboard/stylesheets/dnd.less
b/superset-frontend/src/dashboard/stylesheets/dnd.less
index cb29c09..19df3ad 100644
--- a/superset-frontend/src/dashboard/stylesheets/dnd.less
+++ b/superset-frontend/src/dashboard/stylesheets/dnd.less
@@ -28,6 +28,16 @@
width: 100%;
}
+.dragdroppable-column {
+ .resizable-container {
+ span {
+ div {
+ z-index: @z-index-above-dashboard-charts;
+ }
+ }
+ }
+}
+
/* drop indicators */
.drop-indicator {
display: block;
diff --git a/superset-frontend/src/dashboard/stylesheets/popover-menu.less
b/superset-frontend/src/dashboard/stylesheets/popover-menu.less
index 512f1a3..5ab2b87 100644
--- a/superset-frontend/src/dashboard/stylesheets/popover-menu.less
+++ b/superset-frontend/src/dashboard/stylesheets/popover-menu.less
@@ -30,11 +30,11 @@
.with-popover-menu--focused:after {
content: '';
position: absolute;
- top: 1px;
- left: -1px;
+ top: 0px;
+ left: 0px;
width: 100%;
height: 100%;
- box-shadow: inset 0 0 0 2px @indicator-color;
+ border: 2px solid @indicator-color;
pointer-events: none;
}