[incubator-superset] branch master updated: Make spacings in Settings menu more consistent (#11709)

[yjc]

This is an automated email from the ASF dual-hosted git repository.

yjc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 63ef649  Make spacings in Settings menu more consistent (#11709)
63ef649 is described below

commit 63ef649d1dc47f13e95ff1e78a31206f270c334c
Author: Kamil Gabryjelski <kamil.gabryjel...@gmail.com>
AuthorDate: Thu Nov 19 22:01:53 2020 +0100

    Make spacings in Settings menu more consistent (#11709)
---
 superset-frontend/src/components/Menu/Menu.tsx | 35 ++++++++++++++++++--------
 1 file changed, 25 insertions(+), 10 deletions(-)

diff --git a/superset-frontend/src/components/Menu/Menu.tsx 
b/superset-frontend/src/components/Menu/Menu.tsx
index 1efb44b..fa8ab23 100644
--- a/superset-frontend/src/components/Menu/Menu.tsx
+++ b/superset-frontend/src/components/Menu/Menu.tsx
@@ -134,6 +134,19 @@ const StyledHeader = styled.header`
     display: flex;
     align-items: center;
   }
+
+  .ant-menu {
+    .ant-menu-item-group-title {
+      padding-bottom: ${({ theme }) => theme.gridUnit}px;
+    }
+    .ant-menu-item {
+      margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
+    }
+    .about-section {
+      margin: ${({ theme }) => theme.gridUnit}px 0
+        ${({ theme }) => theme.gridUnit * 2}px;
+    }
+  }
 `;
 
 export function Menu({
@@ -196,16 +209,18 @@ export function Menu({
                     key="about-section"
                     title={t('About')}
                   >
-                    {navbarRight.version_string && (
-                      <li className="version-info">
-                        <span>Version: {navbarRight.version_string}</span>
-                      </li>
-                    )}
-                    {navbarRight.version_sha && (
-                      <li className="version-info">
-                        <span>SHA: {navbarRight.version_sha}</span>
-                      </li>
-                    )}
+                    <div className="about-section">
+                      {navbarRight.version_string && (
+                        <li className="version-info">
+                          <span>Version: {navbarRight.version_string}</span>
+                        </li>
+                      )}
+                      {navbarRight.version_sha && (
+                        <li className="version-info">
+                          <span>SHA: {navbarRight.version_sha}</span>
+                        </li>
+                      )}
+                    </div>
                   </DropdownMenu.ItemGroup>,
                 ]}
               </DropdownMenu>