This is an automated email from the ASF dual-hosted git repository. villebro pushed a commit to branch 1.0 in repository https://gitbox.apache.org/repos/asf/superset.git
commit 342f5eae718548a4703d82bf4dc14887af19cd7e Author: Michael S. Molina <[email protected]> AuthorDate: Fri Jan 22 02:46:06 2021 -0300 Apply capitalization guidelines - iteration 7 (#12343) (#12453) --- superset-frontend/src/SqlLab/actions/sqlLab.js | 2 +- superset-frontend/src/SqlLab/components/ColumnElement.tsx | 4 ++-- .../src/SqlLab/components/EstimateQueryCostButton.jsx | 6 +++--- superset-frontend/src/SqlLab/components/QueryTable.jsx | 2 +- superset-frontend/src/SqlLab/components/ResultSet.tsx | 8 ++++---- .../src/SqlLab/components/RunQueryActionButton.tsx | 2 +- superset-frontend/src/SqlLab/components/SaveQuery.tsx | 4 ++-- .../src/SqlLab/components/ScheduleQueryButton.jsx | 2 +- superset-frontend/src/SqlLab/components/SouthPane.jsx | 2 +- superset-frontend/src/SqlLab/components/SqlEditor.jsx | 10 +++++----- superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx | 2 +- superset-frontend/src/filters/components/Select/index.ts | 4 ++-- superset-frontend/src/middleware/asyncEvent.ts | 8 ++++---- superset-frontend/src/modules/AnnotationTypes.js | 2 +- superset-frontend/src/profile/components/App.tsx | 4 ++-- 15 files changed, 31 insertions(+), 31 deletions(-) diff --git a/superset-frontend/src/SqlLab/actions/sqlLab.js b/superset-frontend/src/SqlLab/actions/sqlLab.js index ebfca91..1806098 100644 --- a/superset-frontend/src/SqlLab/actions/sqlLab.js +++ b/superset-frontend/src/SqlLab/actions/sqlLab.js @@ -188,7 +188,7 @@ export function scheduleQuery(query) { dispatch( addSuccessToast( t( - 'Your query has been scheduled. To see details of your query, navigate to Saved Queries', + 'Your query has been scheduled. To see details of your query, navigate to Saved queries', ), ), ), diff --git a/superset-frontend/src/SqlLab/components/ColumnElement.tsx b/superset-frontend/src/SqlLab/components/ColumnElement.tsx index b9ead1e..8f1953d 100644 --- a/superset-frontend/src/SqlLab/components/ColumnElement.tsx +++ b/superset-frontend/src/SqlLab/components/ColumnElement.tsx @@ -65,8 +65,8 @@ const iconMap = { index: 'fa-bookmark', }; const tooltipTitleMap = { - pk: 'Primary Key', - fk: 'Foreign Key', + pk: 'Primary key', + fk: 'Foreign key', index: 'Index', }; diff --git a/superset-frontend/src/SqlLab/components/EstimateQueryCostButton.jsx b/superset-frontend/src/SqlLab/components/EstimateQueryCostButton.jsx index b6de813..d5424cd 100644 --- a/superset-frontend/src/SqlLab/components/EstimateQueryCostButton.jsx +++ b/superset-frontend/src/SqlLab/components/EstimateQueryCostButton.jsx @@ -82,12 +82,12 @@ const EstimateQueryCostButton = props => { const { disabled, selectedText, tooltip } = props; const btnText = selectedText - ? t('Estimate Selected Query Cost') - : t('Estimate Cost'); + ? t('Estimate selected query cost') + : t('Estimate cost'); return ( <span className="EstimateQueryCostButton"> <ModalTrigger - modalTitle={t('Cost Estimate')} + modalTitle={t('Cost estimate')} modalBody={renderModalBody()} triggerNode={ <Button diff --git a/superset-frontend/src/SqlLab/components/QueryTable.jsx b/superset-frontend/src/SqlLab/components/QueryTable.jsx index a792764..6342f00 100644 --- a/superset-frontend/src/SqlLab/components/QueryTable.jsx +++ b/superset-frontend/src/SqlLab/components/QueryTable.jsx @@ -144,7 +144,7 @@ const QueryTable = props => { className="ResultsModal" triggerNode={ <Label bsStyle="info" className="pointer"> - {t('view results')} + {t('View results')} </Label> } modalTitle={t('Data preview')} diff --git a/superset-frontend/src/SqlLab/components/ResultSet.tsx b/superset-frontend/src/SqlLab/components/ResultSet.tsx index d54b6bc..0ad2d0e 100644 --- a/superset-frontend/src/SqlLab/components/ResultSet.tsx +++ b/superset-frontend/src/SqlLab/components/ResultSet.tsx @@ -466,7 +466,7 @@ export default class ResultSet extends React.PureComponent< onChange={this.changeSearch} value={this.state.searchText} className="form-control input-sm" - placeholder={t('Filter Results')} + placeholder={t('Filter results')} /> )} </div> @@ -498,7 +498,7 @@ export default class ResultSet extends React.PureComponent< return ( <div className="result-set-error-message"> <ErrorMessageWithStackTrace - title={t('Database Error')} + title={t('Database error')} error={query?.errors?.[0]} subtitle={<MonospaceDiv>{query.errorMessage}</MonospaceDiv>} copyText={query.errorMessage || undefined} @@ -602,7 +602,7 @@ export default class ResultSet extends React.PureComponent< buttonStyle="primary" onClick={() => this.fetchResults(query)} > - {t('Refetch Results')} + {t('Refetch results')} </Button> ); } @@ -623,7 +623,7 @@ export default class ResultSet extends React.PureComponent< buttonSize="small" onClick={() => query.trackingUrl && window.open(query.trackingUrl)} > - {t('Track Job')} + {t('Track job')} </Button> ); } diff --git a/superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx b/superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx index 6a61a0c..1208de3 100644 --- a/superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx +++ b/superset-frontend/src/SqlLab/components/RunQueryActionButton.tsx @@ -48,7 +48,7 @@ const buildText = ( ); } if (selectedText) { - return t('Run Selection'); + return t('Run selection'); } return t('Run'); }; diff --git a/superset-frontend/src/SqlLab/components/SaveQuery.tsx b/superset-frontend/src/SqlLab/components/SaveQuery.tsx index 04dc673..4907684 100644 --- a/superset-frontend/src/SqlLab/components/SaveQuery.tsx +++ b/superset-frontend/src/SqlLab/components/SaveQuery.tsx @@ -169,7 +169,7 @@ export default function SaveQuery({ primaryButtonName={isSaved ? t('Save') : t('Save as')} width="620px" show={showSave} - title={<h4>{t('Save Query')}</h4>} + title={<h4>{t('Save query')}</h4>} footer={[ <> <Button onClick={close} data-test="cancel-query" cta> @@ -181,7 +181,7 @@ export default function SaveQuery({ className="m-r-3" cta > - {isSaved ? t('Save As New') : t('Save')} + {isSaved ? t('Save as new') : t('Save')} </Button> {isSaved && ( <Button diff --git a/superset-frontend/src/SqlLab/components/ScheduleQueryButton.jsx b/superset-frontend/src/SqlLab/components/ScheduleQueryButton.jsx index a1d2411..4444d64 100644 --- a/superset-frontend/src/SqlLab/components/ScheduleQueryButton.jsx +++ b/superset-frontend/src/SqlLab/components/ScheduleQueryButton.jsx @@ -198,7 +198,7 @@ class ScheduleQueryButton extends React.PureComponent { ref={ref => { this.saveModal = ref; }} - modalTitle={t('Schedule Query')} + modalTitle={t('Schedule query')} modalBody={this.renderModalBody()} triggerNode={ <div diff --git a/superset-frontend/src/SqlLab/components/SouthPane.jsx b/superset-frontend/src/SqlLab/components/SouthPane.jsx index bc71157..8abe498 100644 --- a/superset-frontend/src/SqlLab/components/SouthPane.jsx +++ b/superset-frontend/src/SqlLab/components/SouthPane.jsx @@ -177,7 +177,7 @@ export class SouthPane extends React.PureComponent { <Tabs.TabPane tab={t('Results')} key="Results"> {results} </Tabs.TabPane> - <Tabs.TabPane tab={t('Query History')} key="History"> + <Tabs.TabPane tab={t('Query history')} key="History"> <QueryHistory queries={props.editorQueries} actions={props.actions} diff --git a/superset-frontend/src/SqlLab/components/SqlEditor.jsx b/superset-frontend/src/SqlLab/components/SqlEditor.jsx index 3b2e936..ce68a2b 100644 --- a/superset-frontend/src/SqlLab/components/SqlEditor.jsx +++ b/superset-frontend/src/SqlLab/components/SqlEditor.jsx @@ -306,7 +306,7 @@ class SqlEditor extends React.PureComponent { func: () => { this.props.addQueryEditor({ ...this.props.queryEditor, - title: t('Untitled Query'), + title: t('Untitled query'), sql: '', }); }, @@ -698,13 +698,13 @@ class SqlEditor extends React.PureComponent { render() { const createViewModalTitle = this.state.createAs === CtasEnum.VIEW - ? 'Create View As' - : 'Create Table As'; + ? 'CREATE VIEW AS' + : 'CREATE TABLE AS'; const createModalPlaceHolder = this.state.createAs === CtasEnum.VIEW - ? 'Specify name to Create View AS schema in: public' - : 'Specify name to Create Table AS schema in: public'; + ? 'Specify name to CREATE VIEW AS schema in: public' + : 'Specify name to CREATE TABLE AS schema in: public'; return ( <div ref={this.sqlEditorRef} className="SqlEditor"> diff --git a/superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx b/superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx index 7b2179f..550f623 100644 --- a/superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx +++ b/superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx @@ -156,7 +156,7 @@ export default class SqlEditorLeftBar extends React.PureComponent { buttonStyle="danger" onClick={this.resetState} > - <i className="fa fa-bomb" /> {t('Reset State')} + <i className="fa fa-bomb" /> {t('Reset state')} </Button> )} </div> diff --git a/superset-frontend/src/filters/components/Select/index.ts b/superset-frontend/src/filters/components/Select/index.ts index f0d05c3..7f3cb2a 100644 --- a/superset-frontend/src/filters/components/Select/index.ts +++ b/superset-frontend/src/filters/components/Select/index.ts @@ -25,8 +25,8 @@ import thumbnail from './images/thumbnail.png'; export default class AntdFilterSelectPlugin extends ChartPlugin { constructor() { const metadata = new ChartMetadata({ - name: t('Select Filter Plugin'), - description: 'Select Filter Plugin using AntD', + name: t('Select filter plugin'), + description: 'Select filter plugin using AntD', isNativeFilter: true, thumbnail, }); diff --git a/superset-frontend/src/middleware/asyncEvent.ts b/superset-frontend/src/middleware/asyncEvent.ts index b7a4912..20caad9 100644 --- a/superset-frontend/src/middleware/asyncEvent.ts +++ b/superset-frontend/src/middleware/asyncEvent.ts @@ -79,7 +79,7 @@ const initAsyncEvents = (options: AsyncEventOptions) => { try { lastReceivedEventId = localStorage.getItem(LOCALSTORAGE_KEY); } catch (err) { - console.warn('failed to fetch last event Id from localStorage'); + console.warn('Failed to fetch last event Id from localStorage'); } const fetchEvents = makeApi< @@ -114,7 +114,7 @@ const initAsyncEvents = (options: AsyncEventOptions) => { try { localStorage.setItem(LOCALSTORAGE_KEY, lastReceivedEventId as string); } catch (err) { - console.warn('Error saving event ID to localStorage', err); + console.warn('Error saving event Id to localStorage', err); } }; @@ -138,7 +138,7 @@ const initAsyncEvents = (options: AsyncEventOptions) => { const component = componentsByJobId[asyncEvent.job_id]; if (!component) { console.warn( - 'component not found for job_id', + 'Component not found for job_id', asyncEvent.job_id, ); return setLastId(asyncEvent); @@ -156,7 +156,7 @@ const initAsyncEvents = (options: AsyncEventOptions) => { ); break; default: - console.warn('received event with status', asyncEvent.status); + console.warn('Received event with status', asyncEvent.status); } return setLastId(asyncEvent); diff --git a/superset-frontend/src/modules/AnnotationTypes.js b/superset-frontend/src/modules/AnnotationTypes.js index 5741788..1f85561 100644 --- a/superset-frontend/src/modules/AnnotationTypes.js +++ b/superset-frontend/src/modules/AnnotationTypes.js @@ -41,7 +41,7 @@ export const ANNOTATION_TYPES_METADATA = { }, TIME_SERIES: { value: 'TIME_SERIES', - label: 'Time Series', + label: 'Time series', }, }; diff --git a/superset-frontend/src/profile/components/App.tsx b/superset-frontend/src/profile/components/App.tsx index 8642dd7..ec6cec8 100644 --- a/superset-frontend/src/profile/components/App.tsx +++ b/superset-frontend/src/profile/components/App.tsx @@ -59,7 +59,7 @@ export default function App({ user }: AppProps) { key="2" tab={ <div> - <i className="fa fa-paint-brush" /> {t('Created Content')} + <i className="fa fa-paint-brush" /> {t('Created content')} </div> } > @@ -73,7 +73,7 @@ export default function App({ user }: AppProps) { key="3" tab={ <div> - <i className="fa fa-list" /> {t('Recent Activity')} + <i className="fa fa-list" /> {t('Recent activity')} </div> } >
